From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 02/02: gnu: wine64-staging: Copy missing man file.
Date: Tue, 02 Jan 2018 23:25:48 +0100
Message-ID: <87vagjx5hv.fsf@gnu.org>
References: <20180102104042.1024.9064@vcs0.savannah.gnu.org>
	<20180102104045.DDA98206A2@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43002)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1eWV0O-0004NN-Gn
	for guix-devel@gnu.org; Tue, 02 Jan 2018 17:25:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1eWV0K-0006QB-DG
	for guix-devel@gnu.org; Tue, 02 Jan 2018 17:25:56 -0500
Received: from hera.aquilenet.fr ([2a0c:e300::1]:41428)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1eWV0K-0006Pj-5F
	for guix-devel@gnu.org; Tue, 02 Jan 2018 17:25:52 -0500
In-Reply-To: <20180102104045.DDA98206A2@vcs0.savannah.gnu.org> (Rutger
	Helling's message of "Tue, 2 Jan 2018 05:40:45 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Rutger Helling <rhelling@mykolab.com>

Hi,

This is your friendly nitpicking bot!  ;-)

rhelling@mykolab.com (Rutger Helling) skribis:

>                                         "/bin/wine-preloader") (string-ap=
pend
>                                         (assoc-ref %outputs "out")
>                                         "/bin/wine-preloader"))
> +             ;; Copy the missing man file for the wine binary from wine-=
staging.
> +             (system (string-append "gunzip < " (string-append (assoc-ref
> +                                    %build-inputs "wine-staging")
> +                                    "/share/man/man1/wine.1.gz") "> "
> +                                    (string-append (assoc-ref %outputs "=
out")
> +                                    "/share/man/man1/wine.1")))
>               #t))

The indentation of the nested =E2=80=98string-append=E2=80=99 calls is misl=
eading here
(and the nested calls are unnecessary because =E2=80=98string-append=E2=80=
=99 is n-ary.)

Also, I think it=E2=80=99s OK to leave the file compressed (we have a man p=
age
compression phase anyway.)

Thanks!

Ludo=E2=80=99.