From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +KLfFhQNN2LtRwAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 12:16:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8NpdExQNN2I2rwAAauVa8A (envelope-from ) for ; Sun, 20 Mar 2022 12:16:36 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 18ED528BDF for ; Sun, 20 Mar 2022 12:16:36 +0100 (CET) Received: from localhost ([::1]:56192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVtY1-0008N7-FZ for larch@yhetil.org; Sun, 20 Mar 2022 07:16:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVtXX-0008Mz-1h for bug-guix@gnu.org; Sun, 20 Mar 2022 07:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVtXW-0000jt-Pm for bug-guix@gnu.org; Sun, 20 Mar 2022 07:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVtXW-00029V-IB for bug-guix@gnu.org; Sun, 20 Mar 2022 07:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 20 Mar 2022 11:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50329 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Roman Scherer , Maxime Devos Received: via spool by 50329-submit@debbugs.gnu.org id=B50329.16477749598262 (code B ref 50329); Sun, 20 Mar 2022 11:16:02 +0000 Received: (at 50329) by debbugs.gnu.org; 20 Mar 2022 11:15:59 +0000 Received: from localhost ([127.0.0.1]:32924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVtXT-00029C-AL for submit@debbugs.gnu.org; Sun, 20 Mar 2022 07:15:59 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:36784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVtXQ-00028y-W5 for 50329@debbugs.gnu.org; Sun, 20 Mar 2022 07:15:57 -0400 Received: by mail-ej1-f65.google.com with SMTP id bi12so24931972ejb.3 for <50329@debbugs.gnu.org>; Sun, 20 Mar 2022 04:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=mrPaSNJ9ehPoXJ/+cNK3arZy0v/oGpAeBd1Xivv7eng=; b=DzS8IUdhr6T/8gBB0au12rjkH6dTFeIjMf0FlYJYaNTJJh2pfsjSBt643AU0cv9CEk RQJjVgKNjielLVXWTpT4RzqYQtdwsfB4b6Yuon+E49c4Cq2DH00LMy+er3LWG76wOYrN Je5MOJIBluixEV8/ZrC/meE3uAo9vBhLuHYvnyF5Pi2tRPW7Tj/Nfvzst4n+5voZZuKE VJKNEODyNurtghJso3kY1nMjsxe/vgJNxMyiNNXnG9NKnaqjhqsHrfCqKNhB5PrDZpDf J+fZLW2gpnS1xloVRm6+V7NvS4FPOsqNNERt/MkLLtWqhr8BkvGebRb6cDBQjgDdDBQ6 XzJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=mrPaSNJ9ehPoXJ/+cNK3arZy0v/oGpAeBd1Xivv7eng=; b=NfKGpbeQImIpK0BQ7TTy+ZiCQ8746munyZLVFmd1RYQUU3wty0S9EzllTsRXXeyNdU USWY1g9shPEVUSYw1JT1eg3gncnXJ/FnSzv/zsKYAHHgbgfxnClprKa41dhjLiBemaXt S5l/J93vlyEnE8igrLzvj65aNf/IpinzFsn7luqob1lRG7dKCyFRpRUKWgu4T/cDr387 9SI1oUd915rHqomOj/UOdZil0O7/ES8sA+J3WYSeuDjtrR6Oe5hZnmObVMf056oliGDa hFTSgd2kdKK/EHNiPsH0qx0TnC4J8N8ioZL12wPV6pZzDIpFOZr0o2iXCOwpJpNs5seS z1jg== X-Gm-Message-State: AOAM530cIYOW4zrl2wt9aWuLaeE74xqryFoxYLZsu3DWPHg+xhMn4Pxd mZe+jUkG5Xz6zcdd2T2wxrY= X-Google-Smtp-Source: ABdhPJyxfYRLWjBgOTR44xi6FTWWf6j10UjKsfnytnSSjcasb5RiYd5ljmnuHO1xH5tBUOrM3S5t1g== X-Received: by 2002:a17:907:7f19:b0:6df:bfc6:67b8 with SMTP id qf25-20020a1709077f1900b006dfbfc667b8mr9174449ejc.72.1647774951104; Sun, 20 Mar 2022 04:15:51 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id v5-20020a50c405000000b004161123bf7asm6491569edf.67.2022.03.20.04.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 04:15:50 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Sun, 20 Mar 2022 12:15:48 +0100 In-Reply-To: <87sfrc7vqw.fsf@burningswell.com> References: <87fsnevtxi.fsf@burningswell.com> <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> <87wngp6l7n.fsf@burningswell.com> <7333ababd7753976b6165d1ce8d538586089015c.camel@telenet.be> <87sfrc7vqw.fsf@burningswell.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Goaziou , 50329@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647774996; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mrPaSNJ9ehPoXJ/+cNK3arZy0v/oGpAeBd1Xivv7eng=; b=fglUIpm9pNjWm7coi6GfMxIFHAFn5KPi47OEwY/apnAe0+y1zyeQ4hysuuKlRUn+ldWxBU 1qvH5Cffjz193zFyeOwj6KXkVgbJZbFtA2W3kiA3J2mUWbW/N0OiQWsAfHCz1hoqsQehoO NhbtGVBSPIN77FrT+fPYZD8NrM6acPMb7rSo2Qfow2pw0d9k5s9o2tqTH97PvUlzn54mV5 xGAhcgZMcrY3Woj5nny6O/RRjJlNuAriXeDAQ4I/f6f3tDnrrpkZMbAkMY/WCHt7EkF7y6 wzIII0ayUl9ZLVxrmsdiY2mUXgSwqLlYjYM8S8QyDrBPDH6Cb7kLqgrCAtCnBw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647774996; a=rsa-sha256; cv=none; b=qpNYDNgeO7Dffluy6iesouESsK/+g/YRzaQDK9oUFPGjgceC47gNZS4tUYYft0Qj9Gu1ck xlGg2yqX+0rNbnCL9GFOI8I9Cv6Hths0vv5CcAKtGweV/cq0kHQZtocEDPPiaNnym1nZQM J3Aa0GQKIqcJZesnhw0FB6turzKViS4WV+85IW3RTsS3Slq7623hft6zwRmtEuhdGQ1fJt qE470xI8Cmnm7rgBxQN22bacIHBvuUzX9EGBI4L+YIj9bO/ljVEXU5KlQ1CjsCNkHTen6V MHrvg3idn/nBciIDr4NRBUbixKA66nWq2fX1tB7mU8dghb0jlNxmIRE73yyZZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=DzS8IUdh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=DzS8IUdh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 18ED528BDF X-Spam-Score: 3.97 X-Migadu-Scanner: scn0.migadu.com X-TUID: GBb6LHlK0d0h Hi Roman, hi Maxime, Am Sonntag, dem 20.03.2022 um 11:35 +0100 schrieb Roman Scherer: > Hi Maxime, > > ok, I see. Thanks for the explanation. I attached a patch that > removes the icons from the source as per your suggestion. > > What do you think about this one? > > Thanks, Roman. The logic behind your patch LGTM, but it lacks an explanatory comment. Don't worry about resending the patch, though -- I already added the comment locally and am currently looking to also apply this to emacs- company-box. If either of you could check whether those icons are referred to by name in emacs-lsp-treemacs while I'm working on company- box, that'd be appreciated. Cheers