From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>
Cc: 51869@debbugs.gnu.org
Subject: bug#51869: [PATCH] Add emacs-vala-mode
Date: Tue, 16 Nov 2021 18:49:26 +0100 [thread overview]
Message-ID: <b156e1627ae90851f49bb6c4e016cfa4b7566829.camel@gmail.com> (raw)
In-Reply-To: <878rxp3yuk.fsf@planete-kraus.eu>
Hi,
Am Montag, den 15.11.2021, 20:48 +0000 schrieb Vivien Kraus:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> > > Since I don’t have a solution to fix this issue, I went away and
> > > reverted the multiline support. It builds and is useful enough
> > > for LSP to kick in, so I consider it fixed.
> > >
> > > What do you think? Do you have a better fix?
> > Given my superior knowledge of Emacs Lisp (just kidding), I'd guess
> > the order of declarations is wrong. Pull the defcustom before the
> > other thing and it ought to work.
> Unfortunately, it does not. I tried it, but it gives the same error
> message. I’m a bit surprised, but reading the help entry for
> c-lang-defconst, I see there is a lot of information about when
> things are evaluated, so maybe someone smart can parse it and
> understand why we can’t use the custom variable value.
I investigated further and the thing at hand (multiline string support)
is currently buggy in CC-Mode anyway. There are plans to support all
kinds of multiline strings with a new API in an upcoming version,
however vala-mode is not yet written with that in mind. Given this
knowledge, I'd second your decision to disable multiline strings for
now.
> > > + (version "20201218.2109")
> > > + (source
> > > + (origin
> > > + (method git-fetch)
> > > + (uri (git-reference
> > > + (url "https://github.com/rrthomas/vala-mode.git")
> > > + (commit
> > > "d696a8177e94c81ea557ad364a3b3dcc3abbc50f")))
> > Use the (let ((revision ...) (commit ...)) (package ...))
> > convention,
> > adding a note that upstream has no tagged release. Base version
> > appears to be "0.1"
> I didn’t know that convention, so here is the updated patch, still
> waiting for a convincing fix for the multiline strings issue.
I'd use our emacs sexp substitution tools to erase these defconsts and
defcustoms rather than a patch. Other than that LGTM.
Cheers
next prev parent reply other threads:[~2021-11-16 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 14:05 bug#51869: [PATCH] Add emacs-vala-mode Vivien Kraus via Bug reports for GNU Guix
2021-11-15 19:42 ` Liliana Marie Prikler
2021-11-15 20:48 ` Vivien Kraus via Bug reports for GNU Guix
2021-11-16 17:49 ` Liliana Marie Prikler [this message]
2021-11-16 18:12 ` Vivien Kraus via Bug reports for GNU Guix
2021-11-16 19:41 ` Liliana Marie Prikler
2021-11-16 19:48 ` Vivien Kraus via Bug reports for GNU Guix
2021-11-17 17:09 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b156e1627ae90851f49bb6c4e016cfa4b7566829.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=51869@debbugs.gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).