unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>, 51869@debbugs.gnu.org
Subject: bug#51869: [PATCH] Add emacs-vala-mode
Date: Mon, 15 Nov 2021 20:42:16 +0100	[thread overview]
Message-ID: <93b000a9d4d893e23e7b55d306aa385eeca19c78.camel@gmail.com> (raw)
In-Reply-To: <87pmr14ipx.fsf@planete-kraus.eu>

Hi Vivien,

Am Montag, den 15.11.2021, 14:05 +0000 schrieb Vivien Kraus:
> Dear guix,
> 
> There’s a vala mode for emacs. It is not very useful
I'd beg to differ.  Not opening Vala files in fundamental-mode is very
useful.

> The project is not very well maintained
I've experienced the same.  I previously used the melpa importer, so as
to not pollute upstream with it, but given that a patch is needed, we
might as well add it properly.

> Since I don’t have a solution to fix this issue, I went away and
> reverted the multiline support. It builds and is useful enough for
> LSP to kick in, so I consider it fixed.
> 
> What do you think? Do you have a better fix?
Given my superior knowledge of Emacs Lisp (just kidding), I'd guess the
order of declarations is wrong.  Pull the defcustom before the other
thing and it ought to work.

> +   (version "20201218.2109")
> +   (source
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +            (url "https://github.com/rrthomas/vala-mode.git")
> +            (commit "d696a8177e94c81ea557ad364a3b3dcc3abbc50f")))
Use the (let ((revision ...) (commit ...)) (package ...)) convention,
adding a note that upstream has no tagged release.  Base version
appears to be "0.1"

Cheers





  reply	other threads:[~2021-11-15 19:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 14:05 bug#51869: [PATCH] Add emacs-vala-mode Vivien Kraus via Bug reports for GNU Guix
2021-11-15 19:42 ` Liliana Marie Prikler [this message]
2021-11-15 20:48   ` Vivien Kraus via Bug reports for GNU Guix
2021-11-16 17:49     ` Liliana Marie Prikler
2021-11-16 18:12       ` Vivien Kraus via Bug reports for GNU Guix
2021-11-16 19:41         ` Liliana Marie Prikler
2021-11-16 19:48           ` Vivien Kraus via Bug reports for GNU Guix
2021-11-17 17:09             ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93b000a9d4d893e23e7b55d306aa385eeca19c78.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=51869@debbugs.gnu.org \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).