From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>
Cc: 51869-done@debbugs.gnu.org
Subject: bug#51869: [PATCH] Add emacs-vala-mode
Date: Wed, 17 Nov 2021 18:09:53 +0100 [thread overview]
Message-ID: <3df08e59131fca25380c16ac697ef45076257b6b.camel@gmail.com> (raw)
In-Reply-To: <87zgq3svut.fsf@planete-kraus.eu>
Hi,
Am Dienstag, den 16.11.2021, 19:48 +0000 schrieb Vivien Kraus:
> > > + (emacs-substitute-sexps "vala-mode.el"
> > > + (";; Support multiline strings" 'disabled.)
> > > + ("(defcustom vala-multiline-strings nil"
> > > + "This variable is ignored.")))))))
> > This inserts mostly bogus into the file rather than killing the
> > sexps
> > as it should.
>
> The first substitution fully kills the whole sexp (and inserts a
> comment that reads "Support for multiline strings disabled." if you
> don’t read too closely ^^).
That was too sneaky for me :P
> It’s true that the second does not kill the defcustom expansion, but
> since it’s part of the intended public API, I’m not so sure we should
> remove it altogether. I think it’s clearer for the user that way,
> because the two modifications are kind of documented in the source.
>
> Also, it’s shorter.
I'm pretty sure you can still use vala-multiline-strings inside a
custom-set-variables form, it will just do nothing as it ought to.
> Anyway, Here are the two versions, you decide.
I rewrote your batch-edit version to be a little clearer and to leave
documented FIXMEs in the code. I pushed the rewrite, so you should now
be able to use emacs-vala-mode, with or without lsp.
Cheers
prev parent reply other threads:[~2021-11-17 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 14:05 bug#51869: [PATCH] Add emacs-vala-mode Vivien Kraus via Bug reports for GNU Guix
2021-11-15 19:42 ` Liliana Marie Prikler
2021-11-15 20:48 ` Vivien Kraus via Bug reports for GNU Guix
2021-11-16 17:49 ` Liliana Marie Prikler
2021-11-16 18:12 ` Vivien Kraus via Bug reports for GNU Guix
2021-11-16 19:41 ` Liliana Marie Prikler
2021-11-16 19:48 ` Vivien Kraus via Bug reports for GNU Guix
2021-11-17 17:09 ` Liliana Marie Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3df08e59131fca25380c16ac697ef45076257b6b.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=51869-done@debbugs.gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).