From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0IfXJVfvk2F8HwAAgWs5BA (envelope-from ) for ; Tue, 16 Nov 2021 18:50:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kFSfIVfvk2EmWwAA1q6Kng (envelope-from ) for ; Tue, 16 Nov 2021 17:50:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A95C2EF67 for ; Tue, 16 Nov 2021 18:50:15 +0100 (CET) Received: from localhost ([::1]:48648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mn2b0-0005qT-5h for larch@yhetil.org; Tue, 16 Nov 2021 12:50:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mn2ao-0005qL-8m for bug-guix@gnu.org; Tue, 16 Nov 2021 12:50:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mn2ao-0007TX-0K for bug-guix@gnu.org; Tue, 16 Nov 2021 12:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mn2an-0001EA-Tg for bug-guix@gnu.org; Tue, 16 Nov 2021 12:50:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51869: [PATCH] Add emacs-vala-mode Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 16 Nov 2021 17:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51869 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Vivien Kraus Received: via spool by 51869-submit@debbugs.gnu.org id=B51869.16370849774651 (code B ref 51869); Tue, 16 Nov 2021 17:50:01 +0000 Received: (at 51869) by debbugs.gnu.org; 16 Nov 2021 17:49:37 +0000 Received: from localhost ([127.0.0.1]:59058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn2aP-0001Cx-Co for submit@debbugs.gnu.org; Tue, 16 Nov 2021 12:49:37 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn2aN-0001Cb-Eo for 51869@debbugs.gnu.org; Tue, 16 Nov 2021 12:49:35 -0500 Received: by mail-wr1-f66.google.com with SMTP id u1so39185244wru.13 for <51869@debbugs.gnu.org>; Tue, 16 Nov 2021 09:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=O18oEABN1RYyzm8YKOeJsyPMGrIjYrMAe9nsm4WzS+s=; b=XraKBMr8hAtmG9GOzgp3hFGaf5nvEfTAdwOVdvT1/tVjnC2+9utYtzvRBRfiBbH1uB y+nyJnWyz/Q1OL1nwGy1M8zpaHH0gVTItsmLEoiPMjHFcS4oiHDsEQm8RZFNFt01z6Iz nl7wfUbQBCWkDVRPZ+wzpDJoO9B1FlE1fObSgP0iwV1XGb+isd7flZh52zyypW+FaAM0 UZp+oNHkx2DlSBXPCcyPlm+vZhLETuqjv8rzsSQ9Ie1S8wrVW4Q+RIU0ckFtjL9SIyUZ nA/4nP4G2Lhf5eCaPfF5+F+n9j5Nw7uS1y9mrua31ElyXxlKoVn7URFMkkjJqG3NIOCn pyGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=O18oEABN1RYyzm8YKOeJsyPMGrIjYrMAe9nsm4WzS+s=; b=ElYa3ECS/v9PFpw7HMTumzpvjr2wYw0MC6tIIN+5axwDK3c8qy5ogD6X1v/D7T3R4s PYQfnY7frwWhzURNrxkLth2lMz4RSIH/yXPqmKAoLkDk43/XhLvsZ0ivuYjKkZTTxaKW ieArTj8f/XUmlDNEUHp5CVxLNzswvifDXcs+SfwP0Cc+9tPrMxUdDcPam4X6LnKaqYo0 popN+AMQ8wHxSnP1NC9mWv+Ve1iCALusByZZSPLW+cnwI0zqaclIMUp/pyq7VwKLCcU6 S2flkLKvMv97WWLW7ghosF+tTVVgA7BNEVRDZJki8jDaotn462QCyHJLMnS1ZixCs2Po VkuQ== X-Gm-Message-State: AOAM532zpH8J8OjSW2gqWZog+fm/aC4/gMKBUeF2SMj5K08iBL93y69h 6cn2gQYzdJYzAfMqqEuUaHk= X-Google-Smtp-Source: ABdhPJzNDwUIuxykONRKfQ6JQGfXcgq0W+MFvmRWA2neoLCfj4ek16PrjfV3Gd7mw9E4keeANOKlXg== X-Received: by 2002:adf:e8c1:: with SMTP id k1mr11524880wrn.257.1637084969405; Tue, 16 Nov 2021 09:49:29 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id i15sm3660759wmq.18.2021.11.16.09.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 09:49:28 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Tue, 16 Nov 2021 18:49:26 +0100 In-Reply-To: <878rxp3yuk.fsf@planete-kraus.eu> References: <87pmr14ipx.fsf@planete-kraus.eu> <93b000a9d4d893e23e7b55d306aa385eeca19c78.camel@gmail.com> <878rxp3yuk.fsf@planete-kraus.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51869@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637085015; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=O18oEABN1RYyzm8YKOeJsyPMGrIjYrMAe9nsm4WzS+s=; b=cjZi1d0Izw4R97MPbl1vXisJNACeF1hJQRlI0XnUWJrHQ4X9YCoGLrC1giXoAaXP/plc7f 7qZFFPstZvCle3+i4UMup6zpKZ0ALZBljmnjjhXOjG6B2QXNnt1OoYr5/wLtltb7J9npJh cj2zU76Ny7ChFpeKmUapts/fJOiv2feftsPJhC7eD33S2JGTzBsqB8CglBE7so1hpOJENd kAEhv34S+MMmXLH4cTKQGx9vNrGfLsKGxltQuJbTSo6/ZwKu9TGVVqatcLJNUHarv8RNKS 5RwsaNOlpIkRHHYgrLkbr/tmfUuY1yHTtj2PXdL57QQG87cojglbq9ZKRfS5Wg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637085015; a=rsa-sha256; cv=none; b=A3KrnMaCggPnuFiTEcEZUdps3x6kDC5eaym/n2sMfJ40V4o4I8dqkzV39g9oq1DEQpBjdi sNta8FudXsJiE0iB6F2WfqC8gfRaf616Vt/sEYzlqniAiy91QrSxgv9NNCTsOMs9N7A4sj xmXOCuJ14+72TxcJlGXIcW+iqCzljR8/dQZNr/sL/Ngs/s4ffgqFujzKF+iy8iY5axUChT xFwgTfpJC920Wep1/AjBgqXtWnvy7RTYpYPZjanv3koXuj2vHwwo02MHymIPwgJLftDoVj 74FObFCLqHmmsXpQgUjkz1AjXkRQN7D6E7O7XBEQyxcNqAYqvBcp7Xfo/yvPgw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=XraKBMr8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.75 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=XraKBMr8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 4A95C2EF67 X-Spam-Score: -1.75 X-Migadu-Scanner: scn1.migadu.com X-TUID: TVpDzl4u6v0t Hi, Am Montag, den 15.11.2021, 20:48 +0000 schrieb Vivien Kraus: > Liliana Marie Prikler writes: > > > Since I don’t have a solution to fix this issue, I went away and > > > reverted the multiline support. It builds and is useful enough > > > for LSP to kick in, so I consider it fixed. > > > > > > What do you think? Do you have a better fix? > > Given my superior knowledge of Emacs Lisp (just kidding), I'd guess > > the order of declarations is wrong. Pull the defcustom before the > > other thing and it ought to work. > Unfortunately, it does not. I tried it, but it gives the same error > message. I’m a bit surprised, but reading the help entry for > c-lang-defconst, I see there is a lot of information about when > things are evaluated, so maybe someone smart can parse it and > understand why we can’t use the custom variable value. I investigated further and the thing at hand (multiline string support) is currently buggy in CC-Mode anyway. There are plans to support all kinds of multiline strings with a new API in an upcoming version, however vala-mode is not yet written with that in mind. Given this knowledge, I'd second your decision to disable multiline strings for now. > > > + (version "20201218.2109") > > > + (source > > > + (origin > > > + (method git-fetch) > > > + (uri (git-reference > > > + (url "https://github.com/rrthomas/vala-mode.git") > > > + (commit > > > "d696a8177e94c81ea557ad364a3b3dcc3abbc50f"))) > > Use the (let ((revision ...) (commit ...)) (package ...)) > > convention, > > adding a note that upstream has no tagged release. Base version > > appears to be "0.1" > I didn’t know that convention, so here is the updated patch, still > waiting for a convincing fix for the multiline strings issue. I'd use our emacs sexp substitution tools to erase these defconsts and defcustoms rather than a patch. Other than that LGTM. Cheers