From: "Ludovic Courtès" <ludo@gnu.org>
To: Josselin Poiret <dev@jpoiret.xyz>, Mathieu Othacehe <othacehe@gnu.org>
Cc: 55360@debbugs.gnu.org
Subject: bug#55360: [Installer] ‘guix system init’ displays dots instead of progress bars
Date: Mon, 18 Jul 2022 21:58:50 +0200 [thread overview]
Message-ID: <87y1wqw5tx.fsf@gnu.org> (raw)
In-Reply-To: <87pmkko21t.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 11 May 2022 11:23:42 +0200")
Hi!
Ludovic Courtès <ludo@gnu.org> skribis:
> During installation, ‘guix system init’ displays dots instead of
> progress bars for downloads and such.
>
> This suggests that ‘display-download-progress’ gets #:tty? #f. This may
> be a side effect of running it in a pipe in
> ‘run-external-command-with-handler’.
This was introduced by:
commit 0b9fbbb4dd24f227c9a708561ba291f6169ad2e6
Date: Sat Jan 15 14:50:00 2022 +0100
installer: Capture external commands output.
* gnu/installer/utils.scm (run-external-command-with-handler,
run-external-command-with-line-hooks): New variables.
(run-command): Use run-external-command-with-line-hooks.
According to <https://issues.guix.gnu.org/53063#0-lineno9>, the goal was
(unsurprisingly) to log standard output of commands.
I’m not sure it’s a good idea for ‘guix system init’: we’d be logging
mostly progress bars, package names, and the likes to syslog—not super
useful. So I’d suggest not capturing stdout of ‘guix system init’.
However, I wouldn’t mind factorizing the syslog facilities from
2cf65e1d543407bc7db43e7c7d39a215907efebc into, say, (guix syslog), and
have (guix scripts system) use it to log important events.
Thoughts?
What about using ‘run-external-command-with-line-hooks’ for other
commands though? IIUC, the primary use case is file system tools.
My gut feeling is that the cost/benefit ratio isn’t worth it (the cost
here is complexity and maintenance burden of
‘run-external-command-with-handler’ & co.; the benefit is improved
logging).
WDYT?
I can hopefully dedicate a bit of time to this, but I need your
guidance, comrades. :-)
Ludo’.
next prev parent reply other threads:[~2022-07-18 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 9:23 bug#55360: [Installer] ‘guix system init’ displays dots instead of progress bars Ludovic Courtès
2022-07-18 19:58 ` Ludovic Courtès [this message]
2022-10-13 7:04 ` bug#55360: bug#58375: Installer does not show what is being downloaded Mathieu Othacehe
2022-10-13 13:21 ` Ludovic Courtès
2022-10-14 15:44 ` Mathieu Othacehe
2022-10-18 15:17 ` Ludovic Courtès
2022-10-20 14:40 ` bug#55360: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1wqw5tx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=55360@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).