unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
	55360@debbugs.gnu.org, 58375@debbugs.gnu.org
Subject: bug#55360: bug#58375: Installer does not show what is being downloaded
Date: Thu, 13 Oct 2022 15:21:53 +0200	[thread overview]
Message-ID: <87zgdzq2oe.fsf@gnu.org> (raw)
In-Reply-To: <87lepk5hnh.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Thu,  13 Oct 2022 09:04:02 +0200")

Hi!

Mathieu Othacehe <othacehe@gnu.org> skribis:

>> I’m not sure it’s a good idea for ‘guix system init’: we’d be logging
>> mostly progress bars, package names, and the likes to syslog—not super
>> useful.  So I’d suggest not capturing stdout of ‘guix system init’.
>
> In the bug report https://issues.guix.gnu.org/57983 capturing the 'guix
> system init' output highlighted a "guix substitute" crash. So it does
> seem like a useful mechanism, especially while 56005 is still open.

Hmm right.  <https://issues.guix.gnu.org/56005> is not
installer-specific, so it’s annoying that we have to prepare for that,
but we can’t deny such bugs exist and prevent installation.

If we really want to capture the output of ‘guix system init’, then we
need to open a pseudo-terminal with ‘openpty’ & co. instead of ‘pipe’ in
‘run-external-command-with-handler’.  That may be relatively easy
actually.

But then I think this should be used sparsely, maybe only for ‘guix
system init’.

> Now the current situation is also not really acceptable.

Nope.  :-)

> What about hiding the "guix system init" output completely and display
> a progress bar page instead?

I don’t think we can do that (with grafts, only part of the build plan
is known upfront so we don’t even know beforehand how many items will be
built/downloaded).

Also, I think there are two strategies: either we run ‘guix system
init’, in which case we let its output through, or we integrate ‘guix
system init’ functionality in the installer so we have more fine-grain
control over the process, in which case we could also have more
graphical output or something.

That second solution is a lot of work, though.

Thanks,
Ludo’.




  reply	other threads:[~2022-10-13 13:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  9:23 bug#55360: [Installer] ‘guix system init’ displays dots instead of progress bars Ludovic Courtès
2022-07-18 19:58 ` Ludovic Courtès
2022-10-13  7:04   ` bug#55360: bug#58375: Installer does not show what is being downloaded Mathieu Othacehe
2022-10-13 13:21     ` Ludovic Courtès [this message]
2022-10-14 15:44       ` Mathieu Othacehe
2022-10-18 15:17         ` Ludovic Courtès
2022-10-20 14:40           ` bug#55360: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgdzq2oe.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=55360@debbugs.gnu.org \
    --cc=58375@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).