From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
55360@debbugs.gnu.org, 58375@debbugs.gnu.org
Subject: bug#58375: Installer does not show what is being downloaded
Date: Tue, 18 Oct 2022 17:17:47 +0200 [thread overview]
Message-ID: <87czapma90.fsf@gnu.org> (raw)
In-Reply-To: <871qrabeav.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Fri, 14 Oct 2022 17:44:24 +0200")
Hi Mathieu,
Mathieu Othacehe <othacehe@gnu.org> skribis:
> So I implemented your proposal. It seems to be working quite well. As
> discussed on #guix, we could avoid to dump the download bars to the
> syslog if the "guix system init" command succeeds. However, it seems
> quite tricky in the current implementation where the syslog dumping is
> actually a hook (%syslog-line-hook).
Yes.
I haven’t actually tested the patch but it LGTM. One thing to check is
whether ‘terminal-window-size’ returns something sensible for the
pseudo-terminal; it could be that we need an extra ioctl so the
pseudo-terminal has the same size as the actual terminal.
> Fixing this issue, I also realized that when the "guix system init"
> command fails, the user is only offered to resume the installation or
> restart it.
>
> In cases where "guix system init" failed because of a network issue, or
> because a partition was too small, restarting/resuming seems like the
> right thing to do.
>
> However, when the installer failed because "guix system init" crashed or
> segfaulted, restarting/resuming won't probably help, and dumping the
> crash is probably the best way to get help. That's why I added in a
> second patch, a new button "Report the failure" to the
> "run-install-failed-page".
Neat!
> From c6286404e9c4c0dc302c3d398a8f27b050cf4ce0 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <othacehe@gnu.org>
> Date: Fri, 14 Oct 2022 17:28:27 +0200
> Subject: [PATCH 1/2] installer: Run the "guix system init" command in a PTY.
>
> Fixes: <https://issues.guix.gnu.org/55360>
>
> * gnu/installer/utils.scm (run-external-command-with-handler/tty): New
> procedure.
> (run-external-command-with-line-hooks, run-command): Add a TTY? argument.
> * gnu/installer/final.scm (install-system): Call run-command with TTY?
> argument set to #true.
LGTM, modulo the terminal size issue mentioned above.
> From 159b82a013cad8c3c698031cce9ee07956153da3 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <othacehe@gnu.org>
> Date: Fri, 14 Oct 2022 17:33:28 +0200
> Subject: [PATCH 2/2] installer: Propose the user to report a "guix system
> init" failure.
>
> * gnu/installer/newt/final.scm (run-install-failed-page): Add a "Report the
> failure" button.
LGTM.
Thank you!
Ludo’.
next prev parent reply other threads:[~2022-10-18 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 9:23 bug#55360: [Installer] ‘guix system init’ displays dots instead of progress bars Ludovic Courtès
2022-07-18 19:58 ` Ludovic Courtès
2022-10-13 7:04 ` bug#55360: bug#58375: Installer does not show what is being downloaded Mathieu Othacehe
2022-10-13 13:21 ` Ludovic Courtès
2022-10-14 15:44 ` Mathieu Othacehe
2022-10-18 15:17 ` Ludovic Courtès [this message]
2022-10-20 14:40 ` bug#55360: " Mathieu Othacehe
-- strict thread matches above, loose matches on Subject: below --
2022-10-08 10:34 Julien Lepiller
2022-10-08 18:09 ` Josselin Poiret via Bug reports for GNU Guix
2022-10-09 16:56 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czapma90.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=55360@debbugs.gnu.org \
--cc=58375@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).