From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yPdNBhC81WItEAAAbAwnHQ (envelope-from ) for ; Mon, 18 Jul 2022 22:01:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KPwgBhC81WK2BgEAauVa8A (envelope-from ) for ; Mon, 18 Jul 2022 22:01:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D69A4BA5F for ; Mon, 18 Jul 2022 22:01:19 +0200 (CEST) Received: from localhost ([::1]:55410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDWve-0007Xi-R7 for larch@yhetil.org; Mon, 18 Jul 2022 16:01:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDWuQ-0007Uj-IO for bug-guix@gnu.org; Mon, 18 Jul 2022 16:00:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDWuQ-0002IG-67 for bug-guix@gnu.org; Mon, 18 Jul 2022 16:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDWuP-0003RB-SA for bug-guix@gnu.org; Mon, 18 Jul 2022 16:00:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55360: [Installer] =?UTF-8?Q?=E2=80=98guix?= system =?UTF-8?Q?init=E2=80=99?= displays dots instead of progress bars Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 18 Jul 2022 20:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55360 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Josselin Poiret , Mathieu Othacehe Cc: 55360@debbugs.gnu.org Received: via spool by 55360-submit@debbugs.gnu.org id=B55360.165817438213158 (code B ref 55360); Mon, 18 Jul 2022 20:00:01 +0000 Received: (at 55360) by debbugs.gnu.org; 18 Jul 2022 19:59:42 +0000 Received: from localhost ([127.0.0.1]:52153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDWu6-0003QA-IB for submit@debbugs.gnu.org; Mon, 18 Jul 2022 15:59:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDWu2-0003Pv-Bw for 55360@debbugs.gnu.org; Mon, 18 Jul 2022 15:59:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDWtw-0002FE-OW; Mon, 18 Jul 2022 15:59:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=VhxyRYIxexp3uXPBL2ln7aTdRfVYnUyIrhzgPpOvKrQ=; b=ItQL3JHuQo9GdvWmV+jP W9eh+bNoEyZLf0OWieEsTYLIhOEUczHiSLBQwZ2ZZCOwiocVYabw2L5I+KIkFqDwnkkCWT5HF4RUp A4E79MqXrjPYXP1Xeg44uUBf+mDy6gFbjWuRvFB4dAVypaWXmM3Z2FAT2IAwyb0deAhB/G/KhHPqI zFp/H4kSngOKsOc72JTsp7JssvJo/gPhUn2pmxmy5P6sZnW3wndoGWfia6NNRHJv1HSSwLL5Bvsj7 tyJ43l5L2XydhHv6mVmxP/vTg5/EwBwhB+RSxIBc8IjoERqnL98UmKXQuIqbssP7vyywhnO+TSQ25 6QvJT5dGLXCSJw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59822 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDWtI-0005Nb-Ks; Mon, 18 Jul 2022 15:59:06 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87pmkko21t.fsf@gnu.org> Date: Mon, 18 Jul 2022 21:58:50 +0200 In-Reply-To: <87pmkko21t.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 11 May 2022 11:23:42 +0200") Message-ID: <87y1wqw5tx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658174479; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VhxyRYIxexp3uXPBL2ln7aTdRfVYnUyIrhzgPpOvKrQ=; b=VPlzQmNIOklET0AVCCx0Zy+5xlsi7DanzhfCrcc06WRhrcOin4xXgb9Zx1zFT5UByHDFkL tfdEP6KiHm3+kpnWL0t0lZS5Xkcu1IkktLE3pEvJxx0UNkWjNmFZhLHQHkRqrK/H22kEip d7R+u1QItxpyXG6W06DnPUcbbf4YXNBoziqmqg4MoJYFttUUNKomp4Ja2mVfY94QuY/4qS pG/pFIETzcbRrkyxbGATkn59HVR8anVCIn8htUjvArx+ulObAavXjCXRXoID+hNbLtxFGp cwNHFuafMyD7M/MzYRzpSqu6aHsXQEtWlM6hVlOaSsz31uvAS+fo6U/W74TtHw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658174479; a=rsa-sha256; cv=none; b=NO4w8jz+5DBG1jWG3WwdMxLiOrulVYVoqwQ387ZH/Ccj31AbF8yKIuZWxcl75DbXlCuWcI LYvdfpaW4oCjvzy94bTYQ5zHsu/RqBIw6infDpfHuBjJjO9eKYfucAl3EqwO5vRH9QybbF LhAKiYcbHaPct8VfuWLw55gZYwvMRSyCp5rIMSCDPG9tnpxjs52n7/TvUIypLDpSZZPH1q ZYt87M6iUXfAYvnVqVSbu9Ry4NxS9Cds0nE98FrNVOICwmtRSdytxh+NwO0EJ3RLbrwYf4 vJVnUGsLIUVxAJjFjX9+hlbfYSA2XDufbwpu9/2rxVnkxRWzYrlvgGcA7ABYoA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ItQL3JHu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ItQL3JHu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D69A4BA5F X-Spam-Score: -3.84 X-Migadu-Scanner: scn1.migadu.com X-TUID: yRhyiRUSfxen Hi! Ludovic Court=C3=A8s skribis: > During installation, =E2=80=98guix system init=E2=80=99 displays dots ins= tead of > progress bars for downloads and such. > > This suggests that =E2=80=98display-download-progress=E2=80=99 gets #:tty= ? #f. This may > be a side effect of running it in a pipe in > =E2=80=98run-external-command-with-handler=E2=80=99. This was introduced by: commit 0b9fbbb4dd24f227c9a708561ba291f6169ad2e6 Date: Sat Jan 15 14:50:00 2022 +0100 installer: Capture external commands output. * gnu/installer/utils.scm (run-external-command-with-handler, run-external-command-with-line-hooks): New variables. (run-command): Use run-external-command-with-line-hooks. According to , the goal was (unsurprisingly) to log standard output of commands. I=E2=80=99m not sure it=E2=80=99s a good idea for =E2=80=98guix system init= =E2=80=99: we=E2=80=99d be logging mostly progress bars, package names, and the likes to syslog=E2=80=94not su= per useful. So I=E2=80=99d suggest not capturing stdout of =E2=80=98guix syste= m init=E2=80=99. However, I wouldn=E2=80=99t mind factorizing the syslog facilities from 2cf65e1d543407bc7db43e7c7d39a215907efebc into, say, (guix syslog), and have (guix scripts system) use it to log important events. Thoughts? What about using =E2=80=98run-external-command-with-line-hooks=E2=80=99 for= other commands though? IIUC, the primary use case is file system tools. My gut feeling is that the cost/benefit ratio isn=E2=80=99t worth it (the c= ost here is complexity and maintenance burden of =E2=80=98run-external-command-with-handler=E2=80=99 & co.; the benefit is i= mproved logging). WDYT? I can hopefully dedicate a bit of time to this, but I need your guidance, comrades. :-) Ludo=E2=80=99.