* bug#62059: guix style looses comments
@ 2023-03-08 22:20 Maxim Cournoyer
2023-03-16 22:05 ` bug#62059: 'guix style' loses comments Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Maxim Cournoyer @ 2023-03-08 22:20 UTC (permalink / raw)
To: 62059
Hello,
Consider this package:
--8<---------------cut here---------------start------------->8---
(define-public ruby-webrick
(package
(name "ruby-webrick")
(version "1.8.1")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/ruby/webrick")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"1xb0mk3cghdir65nmj0mblprbf21blli7267b6yyvxclh307yp6s"))))
(build-system ruby-build-system)
(arguments (list #:phases #~(modify-phases %standard-phases
(add-after 'extract-gemspec 'delete-problematic-tests
(lambda _
;; The httresponse tests fail for
;; unknown reasons (see:
;; https://github.com/ruby/webrick/issues/112).
(delete-file "test/webrick/test_httpresponse.rb"))))))
(home-page "https://github.com/ruby/webrick")
(synopsis "HTTP server toolkit")
(description "WEBrick is an HTTP server toolkit that can be configured as an
HTTPS server, a proxy server, and a virtual-host server.")
(license license:bsd-2)))
--8<---------------cut here---------------end--------------->8---
After running ./pre-inst-env guix style ruby-webrick, it produces:
--8<---------------cut here---------------start------------->8---
(define-public ruby-webrick
(package
(name "ruby-webrick")
(version "1.8.1")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/ruby/webrick")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"1xb0mk3cghdir65nmj0mblprbf21blli7267b6yyvxclh307yp6s"))))
(build-system ruby-build-system)
(arguments
(list #:phases #~(modify-phases %standard-phases
(add-after 'extract-gemspec 'delete-problematic-tests
(lambda _
(delete-file "test/webrick/test_httpresponse.rb"))))))
(home-page "https://github.com/ruby/webrick")
(synopsis "HTTP server toolkit")
(description
"WEBrick is an HTTP server toolkit that can be configured as an
HTTPS server, a proxy server, and a virtual-host server.")
(license license:bsd-2)))
--8<---------------cut here---------------end--------------->8---
I.e., it lost the comment in the phase. It also causes the longest line
to be 82 chars, while it could have easily broken the line to make it
fit under 80.
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#62059: 'guix style' loses comments
2023-03-08 22:20 bug#62059: guix style looses comments Maxim Cournoyer
@ 2023-03-16 22:05 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2023-03-16 22:05 UTC (permalink / raw)
To: Maxim Cournoyer; +Cc: 62059-done
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> (list #:phases #~(modify-phases %standard-phases
> (add-after 'extract-gemspec 'delete-problematic-tests
> (lambda _
> (delete-file "test/webrick/test_httpresponse.rb"))))))
> (home-page "https://github.com/ruby/webrick")
> (synopsis "HTTP server toolkit")
> (description
> "WEBrick is an HTTP server toolkit that can be configured as an
> HTTPS server, a proxy server, and a virtual-host server.")
> (license license:bsd-2)))
>
> I.e., it lost the comment in the phase.
Fixed in 83128f00e9149f3c1bcd4450eb0ed3620a37149c.
> It also causes the longest line to be 82 chars, while it could have
> easily broken the line to make it fit under 80.
Hmm let’s investigate that separately.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-16 22:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 22:20 bug#62059: guix style looses comments Maxim Cournoyer
2023-03-16 22:05 ` bug#62059: 'guix style' loses comments Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).