From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 62059@debbugs.gnu.org
Subject: bug#62059: guix style looses comments
Date: Wed, 08 Mar 2023 17:20:38 -0500 [thread overview]
Message-ID: <87ttyuubpl.fsf@gmail.com> (raw)
Hello,
Consider this package:
--8<---------------cut here---------------start------------->8---
(define-public ruby-webrick
(package
(name "ruby-webrick")
(version "1.8.1")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/ruby/webrick")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"1xb0mk3cghdir65nmj0mblprbf21blli7267b6yyvxclh307yp6s"))))
(build-system ruby-build-system)
(arguments (list #:phases #~(modify-phases %standard-phases
(add-after 'extract-gemspec 'delete-problematic-tests
(lambda _
;; The httresponse tests fail for
;; unknown reasons (see:
;; https://github.com/ruby/webrick/issues/112).
(delete-file "test/webrick/test_httpresponse.rb"))))))
(home-page "https://github.com/ruby/webrick")
(synopsis "HTTP server toolkit")
(description "WEBrick is an HTTP server toolkit that can be configured as an
HTTPS server, a proxy server, and a virtual-host server.")
(license license:bsd-2)))
--8<---------------cut here---------------end--------------->8---
After running ./pre-inst-env guix style ruby-webrick, it produces:
--8<---------------cut here---------------start------------->8---
(define-public ruby-webrick
(package
(name "ruby-webrick")
(version "1.8.1")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/ruby/webrick")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"1xb0mk3cghdir65nmj0mblprbf21blli7267b6yyvxclh307yp6s"))))
(build-system ruby-build-system)
(arguments
(list #:phases #~(modify-phases %standard-phases
(add-after 'extract-gemspec 'delete-problematic-tests
(lambda _
(delete-file "test/webrick/test_httpresponse.rb"))))))
(home-page "https://github.com/ruby/webrick")
(synopsis "HTTP server toolkit")
(description
"WEBrick is an HTTP server toolkit that can be configured as an
HTTPS server, a proxy server, and a virtual-host server.")
(license license:bsd-2)))
--8<---------------cut here---------------end--------------->8---
I.e., it lost the comment in the phase. It also causes the longest line
to be 82 chars, while it could have easily broken the line to make it
fit under 80.
--
Thanks,
Maxim
next reply other threads:[~2023-03-08 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 22:20 Maxim Cournoyer [this message]
2023-03-16 22:05 ` bug#62059: 'guix style' loses comments Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttyuubpl.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=62059@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).