unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 62059-done@debbugs.gnu.org
Subject: bug#62059: 'guix style' loses comments
Date: Thu, 16 Mar 2023 23:05:19 +0100	[thread overview]
Message-ID: <87y1nw8i8w.fsf@gnu.org> (raw)
In-Reply-To: <87ttyuubpl.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 08 Mar 2023 17:20:38 -0500")

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

>      (list #:phases #~(modify-phases %standard-phases
>                         (add-after 'extract-gemspec 'delete-problematic-tests
>                           (lambda _
>                             (delete-file "test/webrick/test_httpresponse.rb"))))))
>     (home-page "https://github.com/ruby/webrick")
>     (synopsis "HTTP server toolkit")
>     (description
>      "WEBrick is an HTTP server toolkit that can be configured as an
> HTTPS server, a proxy server, and a virtual-host server.")
>     (license license:bsd-2)))
>
> I.e., it lost the comment in the phase.

Fixed in 83128f00e9149f3c1bcd4450eb0ed3620a37149c.

> It also causes the longest line to be 82 chars, while it could have
> easily broken the line to make it fit under 80.

Hmm let’s investigate that separately.

Thanks,
Ludo’.




      reply	other threads:[~2023-03-16 22:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 22:20 bug#62059: guix style looses comments Maxim Cournoyer
2023-03-16 22:05 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1nw8i8w.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=62059-done@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).