From: ludo@gnu.org (Ludovic Courtès)
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 32234@debbugs.gnu.org
Subject: bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread.
Date: Sun, 26 Aug 2018 23:16:23 +0200 [thread overview]
Message-ID: <87va7w6d7c.fsf@gnu.org> (raw)
In-Reply-To: <87lg8tb4rz.fsf@lassieur.org> ("Clément Lassieur"'s message of "Sun, 26 Aug 2018 16:07:12 +0200")
Hi Clément,
Clément Lassieur <clement@lassieur.org> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Excellent, thanks for working on this! This looks great to me, and I
>> think the pros outweigh the cons. Did you check on a big database how
>> well it performs?
>
> Yes, I didn't see any difference. When I use Berlin's database, it
> works well but crashes quickly for another reason (lack of disk space I
> think, and /tmp being tmpfs).
Sounds good (not that it crashes, but that you didn’t see any
difference ;-)).
>> I think I find it nicer to keep the ‘db’ parameter everywhere (except
>> that it’s now a channel instead of an actual database) rather than using
>> this global variable.
>>
>> WDYT?
>
> That 'db' parameter made sense before, because there were different
> database connections: one per fiber. But now that there is only one
> global channel accessible from everywhere, I can't find any use for a
> 'db-channel' parameter.
>
> Also, using two differents channels for the same database would be a
> bug, it would break the serialization mechanism.
>
> And I don't think using several databases (with one channel per
> database) would make sense either.
These are all good points, indeed. I’m mildly reluctant to the global
parameter, but if you prefer it that way, I don’t mind; the end result
matters more than this tiny issue anyway!
So: LGTM.
Thank you!
Ludo’.
next prev parent reply other threads:[~2018-08-26 21:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 9:57 bug#32234: Cuirass: The SQLite built in busy handler might block the Fibers scheduler Clément Lassieur
2018-07-23 9:18 ` Ludovic Courtès
2018-07-23 13:42 ` Clément Lassieur
2018-07-23 14:57 ` Ludovic Courtès
2018-07-23 16:18 ` Clément Lassieur
2018-07-23 20:11 ` Ludovic Courtès
2018-08-06 19:27 ` bug#32234: [PATCH 1/2] utils: Avoid deadlock when WITH-CRITICAL-SECTION calls are nested Clément Lassieur
2018-08-06 19:27 ` bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread Clément Lassieur
2018-08-06 19:35 ` Clément Lassieur
2018-08-19 14:06 ` Ludovic Courtès
2018-08-26 14:07 ` Clément Lassieur
2018-08-26 21:16 ` Ludovic Courtès [this message]
2018-08-27 13:47 ` Clément Lassieur
2018-08-27 12:41 ` Danny Milosavljevic
2018-08-27 13:18 ` Clément Lassieur
2018-08-27 14:23 ` Danny Milosavljevic
2018-08-27 15:05 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va7w6d7c.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=32234@debbugs.gnu.org \
--cc=clement@lassieur.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).