From: "Clément Lassieur" <clement@lassieur.org>
To: 32234@debbugs.gnu.org
Subject: bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread.
Date: Mon, 06 Aug 2018 21:35:08 +0200 [thread overview]
Message-ID: <87r2jbmgpf.fsf@lassieur.org> (raw)
In-Reply-To: <20180806192736.1747-2-clement@lassieur.org>
Hi,
Clément Lassieur <clement@lassieur.org> writes:
[...]
> bin/cuirass.in | 23 +-
> src/cuirass/base.scm | 94 +++----
> src/cuirass/database.scm | 550 +++++++++++++++++++++------------------
> src/cuirass/http.scm | 136 +++++-----
> src/cuirass/utils.scm | 23 +-
> tests/database.scm | 103 ++++----
> tests/http.scm | 21 +-
> 7 files changed, 494 insertions(+), 456 deletions(-)
Pros:
- fix the fact that long SQL queries block the scheduler
- simplify the code, and make it more uniform
Cons:
- we don't take advantage of the SQLite multi-threading features
anymore
I've run some tests, and I didn't see any difference in terms of
performance.
Clément
next prev parent reply other threads:[~2018-08-06 19:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 9:57 bug#32234: Cuirass: The SQLite built in busy handler might block the Fibers scheduler Clément Lassieur
2018-07-23 9:18 ` Ludovic Courtès
2018-07-23 13:42 ` Clément Lassieur
2018-07-23 14:57 ` Ludovic Courtès
2018-07-23 16:18 ` Clément Lassieur
2018-07-23 20:11 ` Ludovic Courtès
2018-08-06 19:27 ` bug#32234: [PATCH 1/2] utils: Avoid deadlock when WITH-CRITICAL-SECTION calls are nested Clément Lassieur
2018-08-06 19:27 ` bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread Clément Lassieur
2018-08-06 19:35 ` Clément Lassieur [this message]
2018-08-19 14:06 ` Ludovic Courtès
2018-08-26 14:07 ` Clément Lassieur
2018-08-26 21:16 ` Ludovic Courtès
2018-08-27 13:47 ` Clément Lassieur
2018-08-27 12:41 ` Danny Milosavljevic
2018-08-27 13:18 ` Clément Lassieur
2018-08-27 14:23 ` Danny Milosavljevic
2018-08-27 15:05 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2jbmgpf.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=32234@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).