From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#32234: [PATCH 2/2] database: Serialize all database accesses in a
	thread.
Date: Sun, 26 Aug 2018 23:16:23 +0200
Message-ID: <87va7w6d7c.fsf@gnu.org>
References: <20180806192736.1747-1-clement@lassieur.org>
	<20180806192736.1747-2-clement@lassieur.org> <87zhxih2no.fsf@gnu.org>
	<87lg8tb4rz.fsf@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fu2P9-00016M-Ol
	for bug-guix@gnu.org; Sun, 26 Aug 2018 17:17:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fu2P8-0005pa-I3
	for bug-guix@gnu.org; Sun, 26 Aug 2018 17:17:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56681)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fu2P8-0005pQ-EP
	for bug-guix@gnu.org; Sun, 26 Aug 2018 17:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fu2P8-00026l-8k
	for bug-guix@gnu.org; Sun, 26 Aug 2018 17:17:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.32234.B32234.15353181938064@debbugs.gnu.org>
In-Reply-To: <87lg8tb4rz.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?=
	Lassieur"'s message of "Sun, 26 Aug 2018 16:07:12 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: 32234@debbugs.gnu.org

Hi Cl=C3=A9ment,

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Excellent, thanks for working on this!  This looks great to me, and I
>> think the pros outweigh the cons.  Did you check on a big database how
>> well it performs?
>
> Yes, I didn't see any difference.  When I use Berlin's database, it
> works well but crashes quickly for another reason (lack of disk space I
> think, and /tmp being tmpfs).

Sounds good (not that it crashes, but that you didn=E2=80=99t see any
difference ;-)).

>> I think I find it nicer to keep the =E2=80=98db=E2=80=99 parameter every=
where (except
>> that it=E2=80=99s now a channel instead of an actual database) rather th=
an using
>> this global variable.
>>
>> WDYT?
>
> That 'db' parameter made sense before, because there were different
> database connections: one per fiber.  But now that there is only one
> global channel accessible from everywhere, I can't find any use for a
> 'db-channel' parameter.
>
> Also, using two differents channels for the same database would be a
> bug, it would break the serialization mechanism.
>
> And I don't think using several databases (with one channel per
> database) would make sense either.

These are all good points, indeed.  I=E2=80=99m mildly reluctant to the glo=
bal
parameter, but if you prefer it that way, I don=E2=80=99t mind; the end res=
ult
matters more than this tiny issue anyway!

So: LGTM.

Thank you!

Ludo=E2=80=99.