bug#37860: qemu-4.1.0 build failure

bug#37860: qemu-4.1.0 build failure

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events: assertion failed: (err == 0)
ERROR - Bail out! ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events: assertion failed: (err == 0)

Four times in a row now.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#37860: qemu-4.1.0 build failure

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

On Mon, 21 Oct 2019 23:39:32 +0200
Danny Milosavljevic <dannym@scratchpost.org> wrote:

> ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events: assertion failed: (err == 0)
> ERROR - Bail out! ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events: assertion failed: (err == 0)
> 
> Four times in a row now.

guix commit 05b0b050bce644d96ed2222b7d88414f50bb23d9

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#37860: qemu-4.1.0 build failure

[Miguel Arruga Vivas]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> wrote:
> On Mon, 21 Oct 2019 23:39:32 +0200
> Danny Milosavljevic <dannym@scratchpost.org> wrote:
> 
> > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events:
> > assertion failed: (err == 0) ERROR - Bail out!
> > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events:
> > assertion failed: (err == 0)
> > 
> > Four times in a row now.  
> 
> guix commit 05b0b050bce644d96ed2222b7d88414f50bb23d9

I've hit the same error five times in a row too.  The test seems to
depend on the order of notifications between two inotify queues (one
open on the folder and the other one open on the file name).  I don't
know any easy way to fix it, so I propose to comment it out before
check phase as in the attached patch.  What do you think?

Happy hacking!
Miguel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-qemu-Comment-out-failing-test.patch --]
[-- Type: text/x-patch, Size: 1355 bytes --]

From 53b06fdf0ff5fb343ae5548ff816d0f6fa455b96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
 <rosen644835@gmail.com>
Date: Sun, 3 Nov 2019 00:51:08 +0100
Subject: [PATCH] gnu: qemu: Comment out failing test.

* gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Comment
out test-util-filemonitor from check phase.
---
 gnu/packages/virtualization.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index c2f46985f0..3183916174 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -196,6 +196,12 @@ exec smbd $@")))
                ;; fails within the build environment.
                (("check-unit-.* tests/test-char" all)
                 (string-append "# " all)))
+             (substitute* "tests/Makefile.include"
+               ;; Comment out the test-util-filemonitor test, as it depends
+               ;; on a specific order of notification between two
+               ;; qemu_file_monitor queues.
+               (("check-unit-.* tests/test-util-filemonitor" all)
+                (string-append "# " all)))
              #t)))))
     (inputs                                       ; TODO: Add optional inputs.
      `(("alsa-lib" ,alsa-lib)
-- 
2.23.0

bug#37860: qemu-4.1.0 build failure

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Miguel Arruga Vivas <rosen644835@gmail.com> writes:

> Hi Danny,
>
> Danny Milosavljevic <dannym@scratchpost.org> wrote:
>> On Mon, 21 Oct 2019 23:39:32 +0200
>> Danny Milosavljevic <dannym@scratchpost.org> wrote:
>> 
>> > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events:
>> > assertion failed: (err == 0) ERROR - Bail out!
>> > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events:
>> > assertion failed: (err == 0)
>> > 
>> > Four times in a row now.  
>> 
>> guix commit 05b0b050bce644d96ed2222b7d88414f50bb23d9
>
> I've hit the same error five times in a row too.  The test seems to
> depend on the order of notifications between two inotify queues (one
> open on the folder and the other one open on the file name).  I don't
> know any easy way to fix it, so I propose to comment it out before
> check phase as in the attached patch.  What do you think?

Can you report this upstream?  We should probably apply this, but it
would be good to have an upstream bug to link to.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#37860: qemu-4.1.0 build failure

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Hi,

On Sun, 3 Nov 2019 01:27:49 +0100
Miguel Arruga Vivas <rosen644835@gmail.com> wrote:

> I've hit the same error five times in a row too.  The test seems to
> depend on the order of notifications between two inotify queues (one
> open on the folder and the other one open on the file name).  I don't
> know any easy way to fix it, so I propose to comment it out before
> check phase as in the attached patch.  What do you think?

Sounds like a good idea.

Could you also report a bug upstream at https://bugs.launchpad.net/qemu/ ?

I ask you to do it so that you are credited as the discoverer of the cause of
the bug.

If you do it, please amend your patch to guix to include a link to that report,
I'll be happy to commit it to guix.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#37860: [PATCH v2] gnu: qemu: Add upstream patch for failing test.

[Miguel Arruga Vivas]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Hi,

They have solved the problem on qemu's master branch, as the author
kindly told me[1], so I propose this patch to add their patch on top
of our current version.  I've tested it on x86_64, WDYT?

Happy hacking!
Miguel

[1]
https://lists.nongnu.org/archive/html/qemu-devel/2019-11/msg00340.html

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-qemu-Add-upstream-patch-for-failing-test.patch --]
[-- Type: text/x-patch, Size: 1520 bytes --]

From b91245b18c4e66f05ea9dbc37e62be64ae3bbf07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
 <rosen644835@gmail.com>
Date: Fri, 8 Nov 2019 02:13:38 +0100
Subject: [PATCH] gnu: qemu: Add upstream patch for failing test.

* gnu/packages/virtualization.scm (qemu)[patches]: Add upstream patch
to fix tests on linux-libre >= 5.3.
---
 gnu/packages/virtualization.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index f113eee5f7..afe88e16ea 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -114,7 +114,16 @@
                                  version ".tar.xz"))
              (sha256
               (base32
-               "1ih9v6gxgild3m4g80ld4dr3wp9db3bpy203k73fxgc9hqhn0vk5"))))
+               "1ih9v6gxgild3m4g80ld4dr3wp9db3bpy203k73fxgc9hqhn0vk5"))
+             (patches
+              (list
+               ;; XXX: Patch from master branch, to be removed with next
+               ;; upstream release.
+               (qemu-patch
+                "bf9e0313c27d8e6ecd7f7de3d63e1cb25d8f6311"
+                "qemu-tests-make-filemonitor-test-more-robust.patch"
+                (base32
+                 "1242wqpr8id3cn88pzbig3sqh4znml0g0h2mwdmdyhp81blq7s7n"))))))
     (build-system gnu-build-system)
     (arguments
      '(;; Running tests in parallel can occasionally lead to failures, like:
-- 
2.23.0

bug#37860: [PATCH v2] gnu: qemu: Add upstream patch for failing test.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Miguel Arruga Vivas <rosen644835@gmail.com> writes:

> Hi,
>
> They have solved the problem on qemu's master branch, as the author
> kindly told me[1], so I propose this patch to add their patch on top
> of our current version.  I've tested it on x86_64, WDYT?

LGTM, applied!  I edited the comment and commit message to refer back to
this bug report.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]