From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miguel Arruga Vivas Subject: bug#37860: qemu-4.1.0 build failure Date: Sun, 3 Nov 2019 01:27:49 +0100 Message-ID: <20191103012739.128b8114@gmail.com> References: <20191021233932.26e261a2@scratchpost.org> <20191021234827.177e45ea@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/d50CQeq.Okr4IdmLM0XXcNQ" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:41457) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iR3lQ-0003ZY-TT for bug-guix@gnu.org; Sat, 02 Nov 2019 20:29:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iR3lO-0006Tt-QQ for bug-guix@gnu.org; Sat, 02 Nov 2019 20:29:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52672) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iR3lO-0006Rf-JL for bug-guix@gnu.org; Sat, 02 Nov 2019 20:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iR3lO-0005E1-29 for bug-guix@gnu.org; Sat, 02 Nov 2019 20:29:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20191021234827.177e45ea@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic Cc: 37860@debbugs.gnu.org --MP_/d50CQeq.Okr4IdmLM0XXcNQ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Danny, Danny Milosavljevic wrote: > On Mon, 21 Oct 2019 23:39:32 +0200 > Danny Milosavljevic wrote: > > > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events: > > assertion failed: (err == 0) ERROR - Bail out! > > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events: > > assertion failed: (err == 0) > > > > Four times in a row now. > > guix commit 05b0b050bce644d96ed2222b7d88414f50bb23d9 I've hit the same error five times in a row too. The test seems to depend on the order of notifications between two inotify queues (one open on the folder and the other one open on the file name). I don't know any easy way to fix it, so I propose to comment it out before check phase as in the attached patch. What do you think? Happy hacking! Miguel --MP_/d50CQeq.Okr4IdmLM0XXcNQ Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-gnu-qemu-Comment-out-failing-test.patch =46rom 53b06fdf0ff5fb343ae5548ff816d0f6fa455b96 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D Date: Sun, 3 Nov 2019 00:51:08 +0100 Subject: [PATCH] gnu: qemu: Comment out failing test. * gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Comment out test-util-filemonitor from check phase. --- gnu/packages/virtualization.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.= scm index c2f46985f0..3183916174 100644 --- a/gnu/packages/virtualization.scm +++ b/gnu/packages/virtualization.scm @@ -196,6 +196,12 @@ exec smbd $@"))) ;; fails within the build environment. (("check-unit-.* tests/test-char" all) (string-append "# " all))) + (substitute* "tests/Makefile.include" + ;; Comment out the test-util-filemonitor test, as it depends + ;; on a specific order of notification between two + ;; qemu_file_monitor queues. + (("check-unit-.* tests/test-util-filemonitor" all) + (string-append "# " all))) #t))))) (inputs ; TODO: Add optional inp= uts. `(("alsa-lib" ,alsa-lib) --=20 2.23.0 --MP_/d50CQeq.Okr4IdmLM0XXcNQ--