bug#37860: qemu-4.1.0 build failure

[Miguel Arruga Vivas <rosen644835@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> wrote:
> On Mon, 21 Oct 2019 23:39:32 +0200
> Danny Milosavljevic <dannym@scratchpost.org> wrote:
> 
> > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events:
> > assertion failed: (err == 0) ERROR - Bail out!
> > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events:
> > assertion failed: (err == 0)
> > 
> > Four times in a row now.  
> 
> guix commit 05b0b050bce644d96ed2222b7d88414f50bb23d9

I've hit the same error five times in a row too.  The test seems to
depend on the order of notifications between two inotify queues (one
open on the folder and the other one open on the file name).  I don't
know any easy way to fix it, so I propose to comment it out before
check phase as in the attached patch.  What do you think?

Happy hacking!
Miguel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-qemu-Comment-out-failing-test.patch --]
[-- Type: text/x-patch, Size: 1355 bytes --]

From 53b06fdf0ff5fb343ae5548ff816d0f6fa455b96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
 <rosen644835@gmail.com>
Date: Sun, 3 Nov 2019 00:51:08 +0100
Subject: [PATCH] gnu: qemu: Comment out failing test.

* gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Comment
out test-util-filemonitor from check phase.
---
 gnu/packages/virtualization.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index c2f46985f0..3183916174 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -196,6 +196,12 @@ exec smbd $@")))
                ;; fails within the build environment.
                (("check-unit-.* tests/test-char" all)
                 (string-append "# " all)))
+             (substitute* "tests/Makefile.include"
+               ;; Comment out the test-util-filemonitor test, as it depends
+               ;; on a specific order of notification between two
+               ;; qemu_file_monitor queues.
+               (("check-unit-.* tests/test-util-filemonitor" all)
+                (string-append "# " all)))
              #t)))))
     (inputs                                       ; TODO: Add optional inputs.
      `(("alsa-lib" ,alsa-lib)
-- 
2.23.0