* bug#45279: [core-updates] copy-recursively does not throw an error on missing directory
@ 2020-12-16 21:26 Marius Bakke
2020-12-17 11:03 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Marius Bakke @ 2020-12-16 21:26 UTC (permalink / raw)
To: 45279
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
Hello,
On the 'core-updates' branch, using copy-recursively on a nonexistent
directory does not cause a build failure. Instead an error is printed
and the script continues:
(copy-recursively "doesnotexist" output)
[...]
starting phase `install'
i/o error: doesnotexist: No such file or directory
phase `install' succeeded after 0.0 seconds
This is on cc6cb6e80a42355147809b4830053a34d1563994.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#45279: [core-updates] copy-recursively does not throw an error on missing directory
2020-12-16 21:26 bug#45279: [core-updates] copy-recursively does not throw an error on missing directory Marius Bakke
@ 2020-12-17 11:03 ` Ludovic Courtès
2020-12-17 20:23 ` Mark H Weaver
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ludovic Courtès @ 2020-12-17 11:03 UTC (permalink / raw)
To: Marius Bakke; +Cc: 45279
Hi,
Marius Bakke <marius@gnu.org> skribis:
> On the 'core-updates' branch, using copy-recursively on a nonexistent
> directory does not cause a build failure. Instead an error is printed
> and the script continues:
>
> (copy-recursively "doesnotexist" output)
> [...]
> starting phase `install'
> i/o error: doesnotexist: No such file or directory
> phase `install' succeeded after 0.0 seconds
>
> This is on cc6cb6e80a42355147809b4830053a34d1563994.
I think it’s always been this way. Do you think we should change it?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#45279: [core-updates] copy-recursively does not throw an error on missing directory
2020-12-17 11:03 ` Ludovic Courtès
@ 2020-12-17 20:23 ` Mark H Weaver
2020-12-18 3:33 ` zimoun
2024-05-10 13:25 ` Maxim Cournoyer
2 siblings, 0 replies; 5+ messages in thread
From: Mark H Weaver @ 2020-12-17 20:23 UTC (permalink / raw)
To: Ludovic Courtès, Marius Bakke; +Cc: 45279
Ludovic Courtès <ludo@gnu.org> writes:
> Marius Bakke <marius@gnu.org> skribis:
>
>> On the 'core-updates' branch, using copy-recursively on a nonexistent
>> directory does not cause a build failure. Instead an error is printed
>> and the script continues:
>>
>> (copy-recursively "doesnotexist" output)
>> [...]
>> starting phase `install'
>> i/o error: doesnotexist: No such file or directory
>> phase `install' succeeded after 0.0 seconds
>>
>> This is on cc6cb6e80a42355147809b4830053a34d1563994.
>
> I think it’s always been this way. Do you think we should change it?
In general, I think it's a good idea to raise errors for things like
this. Warnings that only end up in build logs are likely to go
unnoticed for a long time.
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#45279: [core-updates] copy-recursively does not throw an error on missing directory
2020-12-17 11:03 ` Ludovic Courtès
2020-12-17 20:23 ` Mark H Weaver
@ 2020-12-18 3:33 ` zimoun
2024-05-10 13:25 ` Maxim Cournoyer
2 siblings, 0 replies; 5+ messages in thread
From: zimoun @ 2020-12-18 3:33 UTC (permalink / raw)
To: Ludovic Courtès, Marius Bakke; +Cc: 45279
Hi,
On Thu, 17 Dec 2020 at 12:03, Ludovic Courtès <ludo@gnu.org> wrote:
> Marius Bakke <marius@gnu.org> skribis:
>
>> On the 'core-updates' branch, using copy-recursively on a nonexistent
>> directory does not cause a build failure. Instead an error is printed
>> and the script continues:
>>
>> (copy-recursively "doesnotexist" output)
>> [...]
>> starting phase `install'
>> i/o error: doesnotexist: No such file or directory
>> phase `install' succeeded after 0.0 seconds
>>
>> This is on cc6cb6e80a42355147809b4830053a34d1563994.
>
> I think it’s always been this way. Do you think we should change it?
An example from bug#45308 [1] using ’copy-file’, it raises an error and
so a failure. If ’copy-recursively’ is used instead, it means that the
build would say «success» and print “i/o error:” somewhere in the long
build log, right? Harder to notice.
As The Zen of Python (python -c 'import this') says: :-)
Errors should never pass silently.
Unless explicitly silenced.
All the best,
simon
1: <http://issues.guix.gnu.org/issue/45308>
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#45279: [core-updates] copy-recursively does not throw an error on missing directory
2020-12-17 11:03 ` Ludovic Courtès
2020-12-17 20:23 ` Mark H Weaver
2020-12-18 3:33 ` zimoun
@ 2024-05-10 13:25 ` Maxim Cournoyer
2 siblings, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2024-05-10 13:25 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 45279, Marius Bakke
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> Marius Bakke <marius@gnu.org> skribis:
>
>> On the 'core-updates' branch, using copy-recursively on a nonexistent
>> directory does not cause a build failure. Instead an error is printed
>> and the script continues:
>>
>> (copy-recursively "doesnotexist" output)
>> [...]
>> starting phase `install'
>> i/o error: doesnotexist: No such file or directory
>> phase `install' succeeded after 0.0 seconds
>>
>> This is on cc6cb6e80a42355147809b4830053a34d1563994.
>
> I think it’s always been this way. Do you think we should change it?
Just stumbled on that. I think we should change it, yes. Maybe we need
a core-updates-next branch, uh.
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-10 13:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 21:26 bug#45279: [core-updates] copy-recursively does not throw an error on missing directory Marius Bakke
2020-12-17 11:03 ` Ludovic Courtès
2020-12-17 20:23 ` Mark H Weaver
2020-12-18 3:33 ` zimoun
2024-05-10 13:25 ` Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).