From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +L38Bjwl3F+wZAAA0tVLHw (envelope-from ) for ; Fri, 18 Dec 2020 03:42:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YP3WAjwl3F/yKgAAB5/wlQ (envelope-from ) for ; Fri, 18 Dec 2020 03:42:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 819CE940429 for ; Fri, 18 Dec 2020 03:42:51 +0000 (UTC) Received: from localhost ([::1]:43942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kq6fJ-00025R-Di for larch@yhetil.org; Thu, 17 Dec 2020 22:42:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kq6eZ-0001qS-D9 for bug-guix@gnu.org; Thu, 17 Dec 2020 22:42:11 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kq6eY-00063E-J0 for bug-guix@gnu.org; Thu, 17 Dec 2020 22:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kq6eY-0005QM-Eu for bug-guix@gnu.org; Thu, 17 Dec 2020 22:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45279: [core-updates] copy-recursively does not throw an error on missing directory Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 18 Dec 2020 03:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45279 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Marius Bakke Received: via spool by 45279-submit@debbugs.gnu.org id=B45279.160826291420835 (code B ref 45279); Fri, 18 Dec 2020 03:42:02 +0000 Received: (at 45279) by debbugs.gnu.org; 18 Dec 2020 03:41:54 +0000 Received: from localhost ([127.0.0.1]:37458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq6eP-0005Pz-LF for submit@debbugs.gnu.org; Thu, 17 Dec 2020 22:41:53 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:54362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq6eN-0005Pl-Di for 45279@debbugs.gnu.org; Thu, 17 Dec 2020 22:41:52 -0500 Received: by mail-wm1-f52.google.com with SMTP id c133so879318wme.4 for <45279@debbugs.gnu.org>; Thu, 17 Dec 2020 19:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=gy16ZgrrJ+uRWRxa3qwARjyK7joknenJE1aKqW1ua+U=; b=EjfndfMi4wCikeZKEiu7/EJ/Tt5nd9cnDUJYP7htmTvcN8fFO8qhIbvvUDDvZnryTD PjgiEAxlC9wadmAWqIz/ZzTRSXfxn59MQ2QRy3JKvLtYjyxzHHNmAhKPWPA8As1XSXea W/Ae12uQaNjbEL+o0byiQLjI+S9t1wpQRXbVYytbZoEpogr+usn9/OPs4xk8dn6LFgE/ vNQDmRfBHgurMIXll3PqZvdJT1dP0q8ihOL+YcUCbyns/ySxJyIb3/gQ3d9+e3AilL/0 9t9R2uAknUKElhvujrDHmhVOZKoYHDnjqtDxFWRn/wk+0gEwWgKTmctnep8JUzWMWakf gwIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=gy16ZgrrJ+uRWRxa3qwARjyK7joknenJE1aKqW1ua+U=; b=BVmT9YoeiHV6uxQnsnY9eXnQA3kr6upZa2E20dTm9S+6vnxGzdbUmnp8j7t802rbzZ zFX7ytciZwJGGXAKfMaSC8BSp5XMZXHBWQS8x4hflji8bSYtyAYgxu4eVYUlfZoc0Tsk +Ply4lIAfXFf/U9nMVOlrvYO6HRH4qMu06fiPhlFpneud+Px+QWg0OG42tX+ByJBJ9gv tNcYOG4ox2GKFzjw52rwYsSkIUoPFNQYP0vzUmpjCS3CMti08JiHsZLi6HpFrpBGmex7 dCGHYSMwSECH5g/ZO3fyXzLDq24qjXREhoS3AFyI4dRYhjbE+tis74gsHsDLHpHIWkQZ LCiQ== X-Gm-Message-State: AOAM532QvwU/jRtu5Whg6vbHzJZJ0s+iLQjgBlXo24N75iQLl7QMuqGm eX5emma9kuDX9usS09uePAm1tJ/QX8M= X-Google-Smtp-Source: ABdhPJwsLSvsAvr6vV0eZLPIyCeRmvwAn1XuhgRT0370TtlvHSk92XfjkgulGKdcl7enUwhc0wjzcA== X-Received: by 2002:a1c:4c14:: with SMTP id z20mr2192409wmf.149.1608262905565; Thu, 17 Dec 2020 19:41:45 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id 94sm12396059wrq.22.2020.12.17.19.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Dec 2020 19:41:45 -0800 (PST) From: zimoun In-Reply-To: <87lfdwk83q.fsf@gnu.org> References: <87h7ol8msy.fsf@gnu.org> <87lfdwk83q.fsf@gnu.org> Date: Fri, 18 Dec 2020 04:33:45 +0100 Message-ID: <86lfdvn5ye.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45279@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=EjfndfMi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 819CE940429 X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: HVq+Al86ARfL Hi, On Thu, 17 Dec 2020 at 12:03, Ludovic Court=C3=A8s wrote: > Marius Bakke skribis: > >> On the 'core-updates' branch, using copy-recursively on a nonexistent >> directory does not cause a build failure. Instead an error is printed >> and the script continues: >> >> (copy-recursively "doesnotexist" output) >> [...] >> starting phase `install' >> i/o error: doesnotexist: No such file or directory >> phase `install' succeeded after 0.0 seconds >> >> This is on cc6cb6e80a42355147809b4830053a34d1563994. > > I think it=E2=80=99s always been this way. Do you think we should change= it? An example from bug#45308 [1] using =E2=80=99copy-file=E2=80=99, it raises = an error and so a failure. If =E2=80=99copy-recursively=E2=80=99 is used instead, it me= ans that the build would say =C2=ABsuccess=C2=BB and print =E2=80=9Ci/o error:=E2=80=9D = somewhere in the long build log, right? Harder to notice. As The Zen of Python (python -c 'import this') says: :-) Errors should never pass silently. Unless explicitly silenced. All the best, simon 1: