From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>, "Marius Bakke" <marius@gnu.org>
Cc: 45279@debbugs.gnu.org
Subject: bug#45279: [core-updates] copy-recursively does not throw an error on missing directory
Date: Fri, 18 Dec 2020 04:33:45 +0100 [thread overview]
Message-ID: <86lfdvn5ye.fsf@gmail.com> (raw)
In-Reply-To: <87lfdwk83q.fsf@gnu.org>
Hi,
On Thu, 17 Dec 2020 at 12:03, Ludovic Courtès <ludo@gnu.org> wrote:
> Marius Bakke <marius@gnu.org> skribis:
>
>> On the 'core-updates' branch, using copy-recursively on a nonexistent
>> directory does not cause a build failure. Instead an error is printed
>> and the script continues:
>>
>> (copy-recursively "doesnotexist" output)
>> [...]
>> starting phase `install'
>> i/o error: doesnotexist: No such file or directory
>> phase `install' succeeded after 0.0 seconds
>>
>> This is on cc6cb6e80a42355147809b4830053a34d1563994.
>
> I think it’s always been this way. Do you think we should change it?
An example from bug#45308 [1] using ’copy-file’, it raises an error and
so a failure. If ’copy-recursively’ is used instead, it means that the
build would say «success» and print “i/o error:” somewhere in the long
build log, right? Harder to notice.
As The Zen of Python (python -c 'import this') says: :-)
Errors should never pass silently.
Unless explicitly silenced.
All the best,
simon
1: <http://issues.guix.gnu.org/issue/45308>
next prev parent reply other threads:[~2020-12-18 3:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 21:26 bug#45279: [core-updates] copy-recursively does not throw an error on missing directory Marius Bakke
2020-12-17 11:03 ` Ludovic Courtès
2020-12-17 20:23 ` Mark H Weaver
2020-12-18 3:33 ` zimoun [this message]
2024-05-10 13:25 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lfdvn5ye.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=45279@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).