From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YCjBARLETmNScgAAbAwnHQ (envelope-from ) for ; Tue, 18 Oct 2022 17:19:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wDN+ARLETmOEqAAAauVa8A (envelope-from ) for ; Tue, 18 Oct 2022 17:19:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 913FF3A5D1 for ; Tue, 18 Oct 2022 17:19:45 +0200 (CEST) Received: from localhost ([::1]:36956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okoNc-0005Ge-Aa for larch@yhetil.org; Tue, 18 Oct 2022 11:19:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoMw-0005Cb-SL for bug-guix@gnu.org; Tue, 18 Oct 2022 11:19:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okoMw-0006Sc-HK for bug-guix@gnu.org; Tue, 18 Oct 2022 11:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1okoMw-0007iM-9u for bug-guix@gnu.org; Tue, 18 Oct 2022 11:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58375: Installer does not show what is being downloaded Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 18 Oct 2022 15:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58375 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: Josselin Poiret , 55360@debbugs.gnu.org, 58375@debbugs.gnu.org Received: via spool by 58375-submit@debbugs.gnu.org id=B58375.166610630329591 (code B ref 58375); Tue, 18 Oct 2022 15:19:02 +0000 Received: (at 58375) by debbugs.gnu.org; 18 Oct 2022 15:18:23 +0000 Received: from localhost ([127.0.0.1]:53789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoM7-0007gy-Tp for submit@debbugs.gnu.org; Tue, 18 Oct 2022 11:18:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoLr-0007gB-L2; Tue, 18 Oct 2022 11:18:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoLl-0006Jn-So; Tue, 18 Oct 2022 11:17:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/kSe6w2Cm36fLYagT5nqSB5UV6ylkOgU95xK3KcF49w=; b=Gvem/dLEK4jqtlGoNsRs EYBnSj4pCjAacFYj8DZdLQlHLWxr6FWIKCqgtCgCOqOoZ3mWAx3TruZC3xQt0fe/CD/m3LHIT0PYz bzn899uIxWb4oP8dpWIFYoqEmrm81KbFmTWFltkh30te5pybINXzdxDh2211X4DwV/CnFvK9uKgV3 AomrJV4tw4XhNAVY4Bc70vQrqb2mOLcW4ifr/2MSgAxj+t2Z/1nSoVITEFirj8aR+FpQyoYrWlKvM Js+PpZ/DMUIxJKR+pNUaV6pcYfaX2NqmKijyb3KnyNDctyFRy4k36WetWf+3z5ToTbgTVh9X9hILi N8C3wX/2wzaxWg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41874 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoLk-0004N5-Oe; Tue, 18 Oct 2022 11:17:48 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87pmkko21t.fsf@gnu.org> <87y1wqw5tx.fsf@gnu.org> <87lepk5hnh.fsf_-_@gnu.org> <87zgdzq2oe.fsf@gnu.org> <871qrabeav.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 27 =?UTF-8?Q?Vend=C3=A9miaire?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Piment X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 18 Oct 2022 17:17:47 +0200 In-Reply-To: <871qrabeav.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Fri, 14 Oct 2022 17:44:24 +0200") Message-ID: <87czapma90.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666106385; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/kSe6w2Cm36fLYagT5nqSB5UV6ylkOgU95xK3KcF49w=; b=eviFJG3mz8MDbRbEIQipxDVY1Zqs+rdstWKQGtRHcBEU2qOiiu4rJirrbZyYLnjPIswvy8 FS1dzFHDGfzJ3XfsUu2BW5HMbXQ9Sz6dJ96nwSnuFai8h+e2h5c20paAX8CT5L/vMhfAjH YjXNWnls5v3A7fjxDSDZ2zoK5SE9WOGdfOqm9JLkD7EvzK8QGHRNiJCDiHhvEckTGxsFZ+ 9ZHWT3z3dQa2cEQXiq2PUbT4iDO+MGQ6kdPQ33zbtpZt1g+iP8AfEfBrmr4AzrQynDMJ0x j3ofJnigv5vft+PjsgkWs4JGdQhmGRvY8V+M7rfgxYRImbBTJSDzg03WLiIIiA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666106385; a=rsa-sha256; cv=none; b=jphvp5jXkh7uWlp7SkR0OocuYgORZnV4yl90f05R0eKmthjXA/6LgAFHgIlUeFwmeksZ/E X72TH0XMai7xXFbloSqRMwpqtLFmgHXojAb9M6aXHQ/Rge29yL/kwAQ7wlijnVcar/d40I MAQztmI8ybwJbbI/bFsSeNvmuW88nzZbI2Wmv0RWaMz4EET760pWo8czF8lllIdBa75Q7F bUzlZmd4SqL2q806z0d67KaO8h8u1fi1dSVbE6AW/Jwc7w5++L6cmfoZacRVaTglZHPIr3 TsefufGJBPPgX/pKSFy0BhenDCWzWc444RMGHuk7eY6GAr24u8fMrzgyw+0tQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="Gvem/dLE"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.72 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="Gvem/dLE"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 913FF3A5D1 X-Spam-Score: -4.72 X-Migadu-Scanner: scn0.migadu.com X-TUID: CobkAMS/3tdt Hi Mathieu, Mathieu Othacehe skribis: > So I implemented your proposal. It seems to be working quite well. As > discussed on #guix, we could avoid to dump the download bars to the > syslog if the "guix system init" command succeeds. However, it seems > quite tricky in the current implementation where the syslog dumping is > actually a hook (%syslog-line-hook). Yes. I haven=E2=80=99t actually tested the patch but it LGTM. One thing to chec= k is whether =E2=80=98terminal-window-size=E2=80=99 returns something sensible f= or the pseudo-terminal; it could be that we need an extra ioctl so the pseudo-terminal has the same size as the actual terminal. > Fixing this issue, I also realized that when the "guix system init" > command fails, the user is only offered to resume the installation or > restart it. > > In cases where "guix system init" failed because of a network issue, or > because a partition was too small, restarting/resuming seems like the > right thing to do. > > However, when the installer failed because "guix system init" crashed or > segfaulted, restarting/resuming won't probably help, and dumping the > crash is probably the best way to get help. That's why I added in a > second patch, a new button "Report the failure" to the > "run-install-failed-page". Neat! > From c6286404e9c4c0dc302c3d398a8f27b050cf4ce0 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Fri, 14 Oct 2022 17:28:27 +0200 > Subject: [PATCH 1/2] installer: Run the "guix system init" command in a P= TY. > > Fixes: > > * gnu/installer/utils.scm (run-external-command-with-handler/tty): New > procedure. > (run-external-command-with-line-hooks, run-command): Add a TTY? argument. > * gnu/installer/final.scm (install-system): Call run-command with TTY? > argument set to #true. LGTM, modulo the terminal size issue mentioned above. > From 159b82a013cad8c3c698031cce9ee07956153da3 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Fri, 14 Oct 2022 17:33:28 +0200 > Subject: [PATCH 2/2] installer: Propose the user to report a "guix system > init" failure. > > * gnu/installer/newt/final.scm (run-install-failed-page): Add a "Report t= he > failure" button. LGTM. Thank you! Ludo=E2=80=99.