unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#28310: guix build -n misses package builds
@ 2017-08-31 19:03 Andreas Enge
  2017-09-01 23:08 ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2017-08-31 19:03 UTC (permalink / raw)
  To: 28310

Hello,

I am right now in the process of updating pari-gp to version 2.9.3.
After building it on a git check-out of three days ago, which went smoothly,
I rebased my patch on today's master and was pleased to see that no rebuild
was needed:

$ ./pre-inst-env guix build pari-gp -n
outputs nothing.

However, once the -n dropped, the gd package gets built.
And then it is starting ruby, which has no connection to pari-gp:
Downloading https://mirror.hydra.gnu.org/guix/nar/229n3pzp5bdmbdvwslg0dxliysas92k5-ruby-2.4.1.tar.xz...
   ruby-2.4.1.tar.xz  9.5MiB                                                                                                       22KiB/s 00:06 [                    ]   1.3%^

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#28310: guix build -n misses package builds
  2017-08-31 19:03 bug#28310: guix build -n misses package builds Andreas Enge
@ 2017-09-01 23:08 ` Ludovic Courtès
  2017-09-02 10:04   ` Andreas Enge
                     ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Ludovic Courtès @ 2017-09-01 23:08 UTC (permalink / raw)
  To: Andreas Enge; +Cc: 28310

Hello,

Andreas Enge <andreas@enge.fr> skribis:

> I am right now in the process of updating pari-gp to version 2.9.3.
> After building it on a git check-out of three days ago, which went smoothly,
> I rebased my patch on today's master and was pleased to see that no rebuild
> was needed:
>
> $ ./pre-inst-env guix build pari-gp -n
> outputs nothing.
>
> However, once the -n dropped, the gd package gets built.
> And then it is starting ruby, which has no connection to pari-gp:
> Downloading https://mirror.hydra.gnu.org/guix/nar/229n3pzp5bdmbdvwslg0dxliysas92k5-ruby-2.4.1.tar.xz...
>    ruby-2.4.1.tar.xz  9.5MiB                                                                                                       22KiB/s 00:06 [                    ]   1.3%^

“-n” now implies “--no-grafts” (commit
fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
need to have -n really perform a dry run.

The downside is that with -n we now see only half of the build plan, and
when we remove -n, we start with the other half of the build plan,
grafting.

The “build continuation” idea of ‘wip-gexp-grafts’, discussed in
<https://bugs.gnu.org/22990>, could in theory help with that.

Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#28310: guix build -n misses package builds
  2017-09-01 23:08 ` Ludovic Courtès
@ 2017-09-02 10:04   ` Andreas Enge
  2017-09-02 20:13     ` Ludovic Courtès
  2017-09-07 12:42   ` Andreas Enge
  2020-03-22 11:48   ` Ludovic Courtès
  2 siblings, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2017-09-02 10:04 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 28310

Hello,

On Sat, Sep 02, 2017 at 01:08:12AM +0200, Ludovic Courtès wrote:
> “-n” now implies “--no-grafts” (commit
> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
> need to have -n really perform a dry run.

if I understand your answer correctly, then no output with "-n" means that
the ungrafted packages are already available in my store.

> The downside is that with -n we now see only half of the build plan, and
> when we remove -n, we start with the other half of the build plan,
> grafting.

Then this other half would just be grafting, which would not require to
download source and build packages locally.

Or are the built packages the replacements for packages with security
updates, that are grafted upon the existing packages?

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#28310: guix build -n misses package builds
  2017-09-02 10:04   ` Andreas Enge
@ 2017-09-02 20:13     ` Ludovic Courtès
  0 siblings, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2017-09-02 20:13 UTC (permalink / raw)
  To: Andreas Enge; +Cc: 28310

Hi,

Andreas Enge <andreas@enge.fr> skribis:

> On Sat, Sep 02, 2017 at 01:08:12AM +0200, Ludovic Courtès wrote:
>> “-n” now implies “--no-grafts” (commit
>> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
>> need to have -n really perform a dry run.
>
> if I understand your answer correctly, then no output with "-n" means that
> the ungrafted packages are already available in my store.

Exactly.

>> The downside is that with -n we now see only half of the build plan, and
>> when we remove -n, we start with the other half of the build plan,
>> grafting.
>
> Then this other half would just be grafting, which would not require to
> download source and build packages locally.

Grafting usually means downloading/building the replacements first, and
finally performing the actual graft.

I agree it makes it harder to follow from a user viewpoint.

Cheers,
Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#28310: guix build -n misses package builds
  2017-09-01 23:08 ` Ludovic Courtès
  2017-09-02 10:04   ` Andreas Enge
@ 2017-09-07 12:42   ` Andreas Enge
  2017-09-07 13:24     ` Ludovic Courtès
  2020-03-22 11:48   ` Ludovic Courtès
  2 siblings, 1 reply; 7+ messages in thread
From: Andreas Enge @ 2017-09-07 12:42 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 28310-done

On Sat, Sep 02, 2017 at 01:08:12AM +0200, Ludovic Courtès wrote:
> “-n” now implies “--no-grafts” (commit
> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
> need to have -n really perform a dry run.
> 
> The downside is that with -n we now see only half of the build plan, and
> when we remove -n, we start with the other half of the build plan,
> grafting.
> 
> The “build continuation” idea of ‘wip-gexp-grafts’, discussed in
> <https://bugs.gnu.org/22990>, could in theory help with that.

Okay, so to simplify, I am closing this bug report.

Andreas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#28310: guix build -n misses package builds
  2017-09-07 12:42   ` Andreas Enge
@ 2017-09-07 13:24     ` Ludovic Courtès
  0 siblings, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2017-09-07 13:24 UTC (permalink / raw)
  To: Andreas Enge; +Cc: 28310

Andreas Enge <andreas@enge.fr> skribis:

> On Sat, Sep 02, 2017 at 01:08:12AM +0200, Ludovic Courtès wrote:
>> “-n” now implies “--no-grafts” (commit
>> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
>> need to have -n really perform a dry run.
>> 
>> The downside is that with -n we now see only half of the build plan, and
>> when we remove -n, we start with the other half of the build plan,
>> grafting.
>> 
>> The “build continuation” idea of ‘wip-gexp-grafts’, discussed in
>> <https://bugs.gnu.org/22990>, could in theory help with that.
>
> Okay, so to simplify, I am closing this bug report.

I’ve reopened it (it’s a real problem after all) so we can keep track of
it, and feel the relief when we finally close it.  :-)

Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#28310: guix build -n misses package builds
  2017-09-01 23:08 ` Ludovic Courtès
  2017-09-02 10:04   ` Andreas Enge
  2017-09-07 12:42   ` Andreas Enge
@ 2020-03-22 11:48   ` Ludovic Courtès
  2 siblings, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2020-03-22 11:48 UTC (permalink / raw)
  To: Andreas Enge; +Cc: 28310-done

Hello,

ludo@gnu.org (Ludovic Courtès) skribis:

> Andreas Enge <andreas@enge.fr> skribis:
>
>> I am right now in the process of updating pari-gp to version 2.9.3.
>> After building it on a git check-out of three days ago, which went smoothly,
>> I rebased my patch on today's master and was pleased to see that no rebuild
>> was needed:
>>
>> $ ./pre-inst-env guix build pari-gp -n
>> outputs nothing.
>>
>> However, once the -n dropped, the gd package gets built.
>> And then it is starting ruby, which has no connection to pari-gp:
>> Downloading https://mirror.hydra.gnu.org/guix/nar/229n3pzp5bdmbdvwslg0dxliysas92k5-ruby-2.4.1.tar.xz...
>>    ruby-2.4.1.tar.xz  9.5MiB                                                                                                       22KiB/s 00:06 [                    ]   1.3%^
>
> “-n” now implies “--no-grafts” (commit
> fd59105c49965db956fac73c68d8b00d068f5d5c).  This was motivated by the
> need to have -n really perform a dry run.
>
> The downside is that with -n we now see only half of the build plan, and
> when we remove -n, we start with the other half of the build plan,
> grafting.

This is now fixed with this patch series:

  https://issues.guix.gnu.org/issue/40130

It does mean that “The following derivations will be built” can be
printed several times during a build.  That’s a natural consequence of
having dynamic dependencies (grafts) in the graph: we can’t always
statically determine what’s going to be built.

> The “build continuation” idea of ‘wip-gexp-grafts’, discussed in
> <https://bugs.gnu.org/22990>, could in theory help with that.

‘with-build-handler’ also has to do with continuations, only in a
different way.  :-)

Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-03-22 11:49 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 19:03 bug#28310: guix build -n misses package builds Andreas Enge
2017-09-01 23:08 ` Ludovic Courtès
2017-09-02 10:04   ` Andreas Enge
2017-09-02 20:13     ` Ludovic Courtès
2017-09-07 12:42   ` Andreas Enge
2017-09-07 13:24     ` Ludovic Courtès
2020-03-22 11:48   ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).