bug#49100: make check fails: %derivation-cache

bug#49100: make check fails: %derivation-cache

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

Hi,

On core-updates (a6c292a6f123acc86429722619ccb51ca54f844f), "make check"
errors out in tests/builders.scm:

--8<---------------cut here---------------start------------->8---
Backtrace:
           1 (primitive-load-path "tests/builders.scm")
In guix/tests.scm:
    146:8  0 (call-with-external-store #<procedure 7f92ff4f7d60 at i…>)

guix/tests.scm:146:8: In procedure call-with-external-store:
error: %derivation-cache: unbound variable
--8<---------------cut here---------------end--------------->8---

The problem appears to have been caused by
7d873f194ca69d6096d28d7a224ab78e83e34fe1 ("build-system: Rewrite using
gexps.").

The attached patch fixes the issue for me.  However, since I'm not sure
how %derivation-cache is or was supposed to be used, I would appreciate
a second opinion.

Note that %derivation-cache has been used to refer to two different
things in the past (see: 3182539875a67f5989c73c3c654fe3138bbc275c).
Note also that even after applying this fix, some tests relying on
call-with-external-store still fail when run (see: bug 47018).

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

bug#49100: make check fails: %derivation-cache

[Ludovic Courtès]

Hi Chris,

Chris Marusich <cmmarusich@gmail.com> skribis:

> On core-updates (a6c292a6f123acc86429722619ccb51ca54f844f), "make check"
> errors out in tests/builders.scm:
>
> Backtrace:
>            1 (primitive-load-path "tests/builders.scm")
> In guix/tests.scm:
>     146:8  0 (call-with-external-store #<procedure 7f92ff4f7d60 at i…>)
>
> guix/tests.scm:146:8: In procedure call-with-external-store:
> error: %derivation-cache: unbound variable
>
> The problem appears to have been caused by
> 7d873f194ca69d6096d28d7a224ab78e83e34fe1 ("build-system: Rewrite using
> gexps.").

Oops, my bad.

> The attached patch fixes the issue for me.  However, since I'm not sure
> how %derivation-cache is or was supposed to be used, I would appreciate
> a second opinion.

You forgot to attach the patch, but I think it’s enough to remove the
‘hash-clear!’ call from ‘call-with-external-store’.

I haven’t checked but if the tests that rely on
‘call-with-external-store’ work for you, feel free to push!

> Note that %derivation-cache has been used to refer to two different
> things in the past (see: 3182539875a67f5989c73c3c654fe3138bbc275c).

(@@ (guix packages) %derivation-cache) on ‘master’ maps <package>
records to the corresponding derivation.  In ‘core-updates’, this cache
no longer exists; it’s superseded by the “object cache”, which is
per-session (part of <store-connection>.)

> Note also that even after applying this fix, some tests relying on
> call-with-external-store still fail when run (see: bug 47018).

Oh right.

HTH,
Ludo’.

bug#49100: make check fails: %derivation-cache

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

>> The attached patch fixes the issue for me.  However, since I'm not sure
>> how %derivation-cache is or was supposed to be used, I would appreciate
>> a second opinion.
>
> You forgot to attach the patch, but I think it’s enough to remove the
> ‘hash-clear!’ call from ‘call-with-external-store’.

Sorry - but yes, that's all it did.  I removed the hash-clear! call.
I've gone ahead and committed this as
7f0af119a1e3ea9d0ae53811b619437b3e942702 on core-updates.

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]