From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id PLlhNZSwz2Dj7QAAgWs5BA (envelope-from ) for ; Sun, 20 Jun 2021 23:18:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6IZWMJSwz2CyVgAA1q6Kng (envelope-from ) for ; Sun, 20 Jun 2021 21:18:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3424213F11 for ; Sun, 20 Jun 2021 23:18:12 +0200 (CEST) Received: from localhost ([::1]:57844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lv4pX-0007u0-0P for larch@yhetil.org; Sun, 20 Jun 2021 17:18:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lv4pO-0007tD-To for bug-guix@gnu.org; Sun, 20 Jun 2021 17:18:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lv4pO-00074A-Ip for bug-guix@gnu.org; Sun, 20 Jun 2021 17:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lv4pO-0007TW-Dk for bug-guix@gnu.org; Sun, 20 Jun 2021 17:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#49100: make check fails: %derivation-cache Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 20 Jun 2021 21:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49100 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Chris Marusich Received: via spool by 49100-submit@debbugs.gnu.org id=B49100.162422385828687 (code B ref 49100); Sun, 20 Jun 2021 21:18:02 +0000 Received: (at 49100) by debbugs.gnu.org; 20 Jun 2021 21:17:38 +0000 Received: from localhost ([127.0.0.1]:34934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lv4p0-0007Sc-2B for submit@debbugs.gnu.org; Sun, 20 Jun 2021 17:17:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lv4oz-0007SJ-GN for 49100@debbugs.gnu.org; Sun, 20 Jun 2021 17:17:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50282) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lv4ou-0006mU-Ah; Sun, 20 Jun 2021 17:17:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41608 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lv4oq-0000Eo-UK; Sun, 20 Jun 2021 17:17:32 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sg1f6orx.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Messidor an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 20 Jun 2021 23:17:27 +0200 In-Reply-To: <87sg1f6orx.fsf@gmail.com> (Chris Marusich's message of "Fri, 18 Jun 2021 10:55:30 -0700") Message-ID: <87eecw8cd4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 49100@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624223892; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=FyzwCcdAOrc2oiZSKC3M1eFtIO4t1OvLg2Ys7AOBp9k=; b=fuSpHz1MiBeWqT/LfJRKrJVppNgs3Thu5VDhpV0m46okUqxfh9bjfaMo8AFs63k9DJjMvy CY9Z+iPQM8kx4lXAl9xI2o1o4xtq+j3wTHeKaR/ugkse9aS4LU7Jv+Y13lL4LStOQ9Ipvk wRgiECJV30xKwXjU2q5txp3UcgQ/QEtWRO4dt8LngoXyGMOgaFLZ9sVk20cyAiQGx2Ai1p wT6oqcMiv4E0kFhTW2AAkeG5Qf5gxAL/lNoMnGEP6TSosb2DOHEi44diz4B4fDF2meSv7F vATHHIQYefzBaqxlUD2sEWSQb+WGTuxP5S61XmMr+xs9nwE+Q+E2/ImMDPSoBg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624223892; a=rsa-sha256; cv=none; b=TLCoagBmAc+9pOy24lbPVueOaALZVEtCZ7GN6yPBCAbluBxeJGsx9KLYnaHOCeafNVyrDB dJIm0OV0QyduhvXu/dGPjCmRpPnaQYl2kRTBZkZi4aVBVjho7tsYQ1Yd5TNttDOgREGXmo 7rn1AEmWr3Jg/1MwCJCm6cRJ3mKZOinZn/g0q74aRDkW63IzIVhJ/yuTrBiUpwWSw3MehH EItRZRxx/MQ9qJ3ujL278TTCYWFKa1QZrNpfnQw6WSqb9JHbOepxDEn0+PgysJmx+AZBet hw5tH/LaFJw8NAJjPiq1JA53bqG2p+yLP6I4AVQdL2QUGAUfSSm58d/Y+3gHhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 3424213F11 X-Spam-Score: -2.93 X-Migadu-Scanner: scn1.migadu.com X-TUID: tmn9cKGeu8D2 Hi Chris, Chris Marusich skribis: > On core-updates (a6c292a6f123acc86429722619ccb51ca54f844f), "make check" > errors out in tests/builders.scm: > > Backtrace: > 1 (primitive-load-path "tests/builders.scm") > In guix/tests.scm: > 146:8 0 (call-with-external-store #) > > guix/tests.scm:146:8: In procedure call-with-external-store: > error: %derivation-cache: unbound variable > > The problem appears to have been caused by > 7d873f194ca69d6096d28d7a224ab78e83e34fe1 ("build-system: Rewrite using > gexps."). Oops, my bad. > The attached patch fixes the issue for me. However, since I'm not sure > how %derivation-cache is or was supposed to be used, I would appreciate > a second opinion. You forgot to attach the patch, but I think it=E2=80=99s enough to remove t= he =E2=80=98hash-clear!=E2=80=99 call from =E2=80=98call-with-external-store= =E2=80=99. I haven=E2=80=99t checked but if the tests that rely on =E2=80=98call-with-external-store=E2=80=99 work for you, feel free to push! > Note that %derivation-cache has been used to refer to two different > things in the past (see: 3182539875a67f5989c73c3c654fe3138bbc275c). (@@ (guix packages) %derivation-cache) on =E2=80=98master=E2=80=99 maps records to the corresponding derivation. In =E2=80=98core-updates=E2=80=99= , this cache no longer exists; it=E2=80=99s superseded by the =E2=80=9Cobject cache=E2= =80=9D, which is per-session (part of .) > Note also that even after applying this fix, some tests relying on > call-with-external-store still fail when run (see: bug 47018). Oh right. HTH, Ludo=E2=80=99.