From: "Ludovic Courtès" <ludo@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 49100@debbugs.gnu.org
Subject: bug#49100: make check fails: %derivation-cache
Date: Sun, 20 Jun 2021 23:17:27 +0200 [thread overview]
Message-ID: <87eecw8cd4.fsf@gnu.org> (raw)
In-Reply-To: <87sg1f6orx.fsf@gmail.com> (Chris Marusich's message of "Fri, 18 Jun 2021 10:55:30 -0700")
Hi Chris,
Chris Marusich <cmmarusich@gmail.com> skribis:
> On core-updates (a6c292a6f123acc86429722619ccb51ca54f844f), "make check"
> errors out in tests/builders.scm:
>
> Backtrace:
> 1 (primitive-load-path "tests/builders.scm")
> In guix/tests.scm:
> 146:8 0 (call-with-external-store #<procedure 7f92ff4f7d60 at i…>)
>
> guix/tests.scm:146:8: In procedure call-with-external-store:
> error: %derivation-cache: unbound variable
>
> The problem appears to have been caused by
> 7d873f194ca69d6096d28d7a224ab78e83e34fe1 ("build-system: Rewrite using
> gexps.").
Oops, my bad.
> The attached patch fixes the issue for me. However, since I'm not sure
> how %derivation-cache is or was supposed to be used, I would appreciate
> a second opinion.
You forgot to attach the patch, but I think it’s enough to remove the
‘hash-clear!’ call from ‘call-with-external-store’.
I haven’t checked but if the tests that rely on
‘call-with-external-store’ work for you, feel free to push!
> Note that %derivation-cache has been used to refer to two different
> things in the past (see: 3182539875a67f5989c73c3c654fe3138bbc275c).
(@@ (guix packages) %derivation-cache) on ‘master’ maps <package>
records to the corresponding derivation. In ‘core-updates’, this cache
no longer exists; it’s superseded by the “object cache”, which is
per-session (part of <store-connection>.)
> Note also that even after applying this fix, some tests relying on
> call-with-external-store still fail when run (see: bug 47018).
Oh right.
HTH,
Ludo’.
next prev parent reply other threads:[~2021-06-20 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 17:55 bug#49100: make check fails: %derivation-cache Chris Marusich
2021-06-20 21:17 ` Ludovic Courtès [this message]
2021-06-23 1:34 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eecw8cd4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=49100@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).