From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 23723@debbugs.gnu.org, Jelle Licht <jlicht@fsfe.org>
Subject: bug#23723: patch-shebang phase breaks symlinks
Date: Thu, 16 Jun 2016 10:16:13 +0200 [thread overview]
Message-ID: <8760t9k0qa.fsf@gnu.org> (raw)
In-Reply-To: <20160616071528.1e56e75b@scratchpost.org> (Danny Milosavljevic's message of "Thu, 16 Jun 2016 07:15:28 +0200")
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> are you sure that's correct?
>
> Compare:
>
> On Sun, 12 Jun 2016 12:29:52 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> + (filter (lambda (file)
>> + (eq? 'regular (lstat file)))
> ^^^^^
> to
>
>> - (let ((s (stat (string-append dir "/" f))))
>> + (let ((s (lstat (string-append dir "/" f))))
>> (eq? 'regular (stat:type s)))))
> ^^^^^^^^^
> .
>
> I think the first is missing a call to stat:type .
Good catch! I’ll adjust it when I commit to ‘core-updates-next’.
Thank you!
Ludo’.
next prev parent reply other threads:[~2016-06-16 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 23:42 bug#23723: patch-shebang phase breaks symlinks Jelle Licht
2016-06-10 12:42 ` Ludovic Courtès
2016-06-11 13:32 ` Jelle Licht
2016-06-12 10:29 ` Ludovic Courtès
2016-06-13 19:50 ` Jelle Licht
2016-06-14 7:56 ` Ludovic Courtès
2016-06-14 8:22 ` Jelle Licht
2016-06-16 5:15 ` Danny Milosavljevic
2016-06-16 8:16 ` Ludovic Courtès [this message]
2016-09-12 19:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760t9k0qa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=23723@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).