From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#23723: patch-shebang phase breaks symlinks
Date: Thu, 16 Jun 2016 10:16:13 +0200
Message-ID: <8760t9k0qa.fsf@gnu.org>
References: <87fusowopk.fsf@fsfe.org> <87r3c51agw.fsf@gnu.org>
	<87r3c33l79.fsf@fsfe.org> <8737oiog2n.fsf@gnu.org>
	<20160616071528.1e56e75b@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bDSU7-0007gf-1r
	for bug-guix@gnu.org; Thu, 16 Jun 2016 04:17:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bDSU2-0004JR-Pp
	for bug-guix@gnu.org; Thu, 16 Jun 2016 04:17:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bDSU2-0004JN-MV
	for bug-guix@gnu.org; Thu, 16 Jun 2016 04:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bDSU2-0002R0-GM
	for bug-guix@gnu.org; Thu, 16 Jun 2016 04:17:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.23723.B23723.14660649899311@debbugs.gnu.org>
In-Reply-To: <20160616071528.1e56e75b@scratchpost.org> (Danny Milosavljevic's
	message of "Thu, 16 Jun 2016 07:15:28 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 23723@debbugs.gnu.org, Jelle Licht <jlicht@fsfe.org>

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> are you sure that's correct?
>
> Compare:
>
> On Sun, 12 Jun 2016 12:29:52 +0200
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> +            (filter (lambda (file)
>> +                      (eq? 'regular (lstat file)))
>                                      ^^^^^
> to
>
>> -                            (let ((s (stat (string-append dir "/" f))))
>> +                            (let ((s (lstat (string-append dir "/" f))))
>>                                (eq? 'regular (stat:type s)))))
>                                                 ^^^^^^^^^
> .
>
> I think the first is missing a call to stat:type .

Good catch!  I=E2=80=99ll adjust it when I commit to =E2=80=98core-updates-=
next=E2=80=99.

Thank you!

Ludo=E2=80=99.