From: ludo@gnu.org (Ludovic Courtès)
To: Jelle Licht <jlicht@fsfe.org>
Cc: 23723-done@debbugs.gnu.org
Subject: bug#23723: patch-shebang phase breaks symlinks
Date: Mon, 12 Sep 2016 21:37:55 +0200 [thread overview]
Message-ID: <87lgywzz70.fsf@gnu.org> (raw)
In-Reply-To: <8737oiog2n.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 12 Jun 2016 12:29:52 +0200")
ludo@gnu.org (Ludovic Courtès) skribis:
> Jelle Licht <jlicht@fsfe.org> skribis:
[...]
>> Also, seeing as my experience with the stat utility and similarly styled
>> programming libraries was lacking, I decided to play around with the
>> definition of `list-of-files': It actually does include symlinks, as
>> (stat:type (stat "some-symlinked-file")) gives us a plain old 'regular.
>> Looking into this a bit more, it seems that calling `stat' gives the
>> exact same results on both the linked-to-file and the symlink to that
>> file.
>>
>> For the particular problem I ran into to be fixed, it is imperative that
>> `list-of-files' of `patch-shebangs' includes the symlink; it does after
>> all need to be patched. The way this patching currently happens just
>> clobbers symlinks.
>
> My bad, indeed, ‘list-of-files’ should use ‘lstat’ instead of ‘stat’.
This was fixed some time ago in core-updates by commit
c13a9feb5b64fd819eaed38a17da0284bbe2b8d9; closing this bug!
Ludo’.
prev parent reply other threads:[~2016-09-12 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 23:42 bug#23723: patch-shebang phase breaks symlinks Jelle Licht
2016-06-10 12:42 ` Ludovic Courtès
2016-06-11 13:32 ` Jelle Licht
2016-06-12 10:29 ` Ludovic Courtès
2016-06-13 19:50 ` Jelle Licht
2016-06-14 7:56 ` Ludovic Courtès
2016-06-14 8:22 ` Jelle Licht
2016-06-16 5:15 ` Danny Milosavljevic
2016-06-16 8:16 ` Ludovic Courtès
2016-09-12 19:37 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgywzz70.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=23723-done@debbugs.gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).