From: ludo@gnu.org (Ludovic Courtès)
To: Jelle Licht <jlicht@fsfe.org>
Cc: 23723@debbugs.gnu.org
Subject: bug#23723: patch-shebang phase breaks symlinks
Date: Fri, 10 Jun 2016 14:42:39 +0200 [thread overview]
Message-ID: <87r3c51agw.fsf@gnu.org> (raw)
In-Reply-To: <87fusowopk.fsf@fsfe.org> (Jelle Licht's message of "Wed, 08 Jun 2016 01:42:31 +0200")
Hello!
Jelle Licht <jlicht@fsfe.org> skribis:
> It seems that the patch-shebang functionality does not deal gracefully
> with symlinks: it just overwrites them!
>
> After struggling somewhat with getting the recently packaged node 6.0.0
> to behave, I found out that `patch-shebang' in (guix build
> gnu-build-system) does not work properly on symlinks.
There’s ‘patch-shebangs’ (plural) in this file, but it explicitly
touches only regular files (see ‘list-of-files’).
However, ‘patch-source-shebangs’ indeed overwrites symlinks. Is it the
one that’s causing problems?
> To illustrate, in this specific case, there was an executable
> script included with the node tarball, namely
> `lib/node-modules/npm/bin/npm-cli.js' with an env-based shebang:
> `/usr/bin/env node'.
>
> As the `node' executable will only be available after the `install'
> phase of the build system, it is not patched before hand. During the
> `install' phase, a symlink is created from `bin/npm' to
> `lib/node-modules/npm/bin/npm-cli.js' (in the store output directory
> this time, of course). Then the `patch-shebangs' phase finds this
> symlink and proceeds to patch it. Instead of transparently following the
> symlink and patching the `npm-cli.js' script, the `npm' symlink is
> overwritten with a shebang-patched copy of `npm-cli.js'.
I don’t think ‘patch-shebangs’ is to blame; could it be
‘patch-source-shebangs’?
Thanks!
Ludo’.
next prev parent reply other threads:[~2016-06-10 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 23:42 bug#23723: patch-shebang phase breaks symlinks Jelle Licht
2016-06-10 12:42 ` Ludovic Courtès [this message]
2016-06-11 13:32 ` Jelle Licht
2016-06-12 10:29 ` Ludovic Courtès
2016-06-13 19:50 ` Jelle Licht
2016-06-14 7:56 ` Ludovic Courtès
2016-06-14 8:22 ` Jelle Licht
2016-06-16 5:15 ` Danny Milosavljevic
2016-06-16 8:16 ` Ludovic Courtès
2016-09-12 19:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3c51agw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=23723@debbugs.gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).