bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

[Janneke Nieuwenhuizen]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Hi,

Make check gives three failures for me on current master

    FAIL: tests/packages     (package->bag)
    FAIL: tests/store-roots  (gc-roots, initial)  
    FAIL: tests/texlive      (texlive->guix-package, meta-package)

using this snippet.

--8<---------------cut here---------------start------------->8---
export SCM_LOG_DRIVER_FLAGS="--select='^(package->bag|gc-roots, initial|texlive->guix-package, meta-package)'"
make check TESTS="tests/packages.scm tests/store-roots.scm tests/texlive.scm"
--8<---------------cut here---------------end--------------->8---

Find log excerpts attached.

I have bisected the first (package->bag) to be broken by

    0dd293b4d9095137c9952e16ca951f887b7e7018
    gnu: Add libc-for-target and glibc/hurd.

but as yet fail to why.

Greetings,
Janneke


[-- Attachment #2: packages.log --]
[-- Type: application/octet-stream, Size: 1345 bytes --]

test-name: package->bag
location: /home/janneke/src/guix/master/tests/packages.scm:1279
source:
+ (test-equal
+   "package->bag"
+   `("foo86-hurd"
+     #f
+     (,(package-source gnu-make))
+     (,(canonical-package glibc))
+     (,(canonical-package coreutils)))
+   (let ((bag (package->bag gnu-make "foo86-hurd")))
+     (list (bag-system bag)
+           (bag-target bag)
+           (assoc-ref (bag-build-inputs bag) "source")
+           (assoc-ref (bag-build-inputs bag) "libc")
+           (assoc-ref (bag-build-inputs bag) "coreutils"))))
expected-value: ("foo86-hurd" #f (#<origin "mirror://gnu/make/make-4.3.tar.gz" #<content-hash sha256:06cfqzpqsvdnsxbysl5p2fgdgxgl9y4p7scpnrfa8z2zgkjdspz0> ("/home/janneke/src/guix/master/gnu/packages/patches/make-impure-dirs.patch") 7fb6b9e3c660>) (#<package glibc@2.35 gnu/packages/commencement.scm:3100 7fb6b9f338f0>) (#<package coreutils@9.1 guix/build-system/gnu.scm:146 7fb6b9f2b210>))
actual-value: ("foo86-hurd" #f (#<origin "mirror://gnu/make/make-4.3.tar.gz" #<content-hash sha256:06cfqzpqsvdnsxbysl5p2fgdgxgl9y4p7scpnrfa8z2zgkjdspz0> ("/home/janneke/src/guix/master/gnu/packages/patches/make-impure-dirs.patch") 7fb6b9e3c660>) (#<package glibc@2.35 gnu/packages/commencement.scm:3100 7fb6bacaa0b0>) (#<package coreutils@9.1 guix/build-system/gnu.scm:146 7fb6b9f2b210>))
result: FAIL


[-- Attachment #3: store-roots.log --]
[-- Type: application/octet-stream, Size: 580 bytes --]

test-name: gc-roots, initial
location: /home/janneke/src/guix/master/tests/store-roots.scm:33
source:
+ (test-equal
+   "gc-roots, initial"
+   (list (string-append %state-directory "/profiles"))
+   (begin
+     (delete-file-recursively
+       (string-append %state-directory "/profiles"))
+     (gc-roots)))
expected-value: ("/home/janneke/src/guix/master/test-tmp/var/9734/profiles")
actual-value: #f
actual-error:
+ (system-error
+   "lstat"
+   "~A: ~S"
+   ("No such file or directory"
+    "/home/janneke/src/guix/master/test-tmp/var/9734/profiles")
+   (2))
result: FAIL

[-- Attachment #4: texlive.log --]
[-- Type: application/octet-stream, Size: 2754 bytes --]

(package (name "texlive-collection-texworks") (version (number->string %texlive-revision)) (source #f) (build-system trivial-build-system) (arguments (list #:builder (gexp (mkdir (ungexp output))))) (propagated-inputs (list texlive-collection-basic)) (home-page "https://www.tug.org/texlive/") (synopsis "TeXworks editor...") (description "See http...") (license (license:fsf-free "https://www.tug.org/texlive/copying.html")))

;;; (fail (package (name "texlive-collection-texworks") (version (number->string %texlive-revision)) (source #f) (build-system trivial-build-system) (arguments (list #:builder (gexp (mkdir (ungexp output))))) (propagated-inputs (list texlive-collection-basic)) (home-page "https://www.tug.org/texlive/") (synopsis "TeXworks editor...") (description "See http...") (license (license:fsf-free "https://www.tug.org/texlive/copying.html"))) #f)
test-name: texlive->guix-package, meta-package
location: /home/janneke/src/guix/master/tests/texlive.scm:521
source:
+ (test-assert
+   "texlive->guix-package, meta-package"
+   (mock ((guix build svn)
+          svn-fetch
+          (lambda* (url
+                    revision
+                    directory
+                    #:key
+                    (svn-command "svn")
+                    (user-name #f)
+                    (password #f)
+                    (recursive? #t))
+            (mkdir-p directory)
+            (with-output-to-file
+              (string-append directory "/foo")
+              (lambda () (display "source")))))
+         (let ((result
+                 (texlive->guix-package
+                   "collection-texworks"
+                   #:package-database
+                   (lambda _ %fake-tlpdb))))
+           (match result
+                  (('package
+                    ('name "texlive-collection-texworks")
+                    ('version _)
+                    ('source #f)
+                    ('build-system 'trivial-build-system)
+                    ('arguments
+                     ('list
+                      '#:builder
+                      ('gexp ('mkdir ('ungexp 'output)))))
+                    ('propagated-inputs
+                     ('list
+                      'texlive-collection-basic
+                      'texlive-texworks))
+                    ('home-page "https://www.tug.org/texlive/")
+                    ('synopsis (? string?))
+                    ('description (? string?))
+                    ('license
+                     ('license:fsf-free
+                      "https://www.tug.org/texlive/copying.html")))
+                   #t)
+                  (_ (begin
+                       (format #t "~s~%" result)
+                       (pk 'fail result #f)))))))
actual-value: #f
result: FAIL

[-- Attachment #5: Type: text/plain, Size: 164 bytes --]


-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

[Josselin Poiret via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

Hi Janneke,

Janneke Nieuwenhuizen <janneke@gnu.org> writes:

> Hi,
>
> Make check gives three failures for me on current master
>
>     FAIL: tests/packages     (package->bag)
>     FAIL: tests/store-roots  (gc-roots, initial)  
>     FAIL: tests/texlive      (texlive->guix-package, meta-package)
>
> using this snippet.

I have local fixes for all of them, but I am not 100% sure about the
gc-roots one.  Ludo, WDYT?  Also, guix-shell fails on the fdes test
locally for me, probably because I'm using zsh.  All should be fine in
the package though.

Best,

Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

bug#64760: [PATCH 1/3] tests: packages: Set system for expected result of package->bag.

[Josselin Poiret via Bug reports for GNU Guix]

From: Josselin Poiret <dev@jpoiret.xyz>

* tests/packages.scm ("package->bag"): Parameterize the expected result by the
system used to lower the package to a bag.
---
 tests/packages.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/packages.scm b/tests/packages.scm
index 2b7ab01f7d..2b4f9f8e90 100644
--- a/tests/packages.scm
+++ b/tests/packages.scm
@@ -1277,8 +1277,9 @@ (define compressors '(("gzip"  . "gz")
 ;;                               #:guile guile))))
 
 (test-equal "package->bag"
-  `("foo86-hurd" #f (,(package-source gnu-make))
-    (,(canonical-package glibc)) (,(canonical-package coreutils)))
+  (parameterize ((%current-system "foo86-hurd"))
+    `("foo86-hurd" #f (,(package-source gnu-make))
+      (,(canonical-package glibc)) (,(canonical-package coreutils))))
   (let ((bag (package->bag gnu-make "foo86-hurd")))
     (list (bag-system bag) (bag-target bag)
           (assoc-ref (bag-build-inputs bag) "source")

base-commit: 182be30fb1a8b847c30492462ec22c08ec7a9849
-- 
2.40.1

bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty.

[Josselin Poiret via Bug reports for GNU Guix]

From: Josselin Poiret <dev@jpoiret.xyz>

* tests/store-roots.scm ("gc-roots, initial"): Set expected result to empty.
Also do not error out if /profiles doesn't exist.
---
 tests/store-roots.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/store-roots.scm b/tests/store-roots.scm
index 9877987a65..d82a29e313 100644
--- a/tests/store-roots.scm
+++ b/tests/store-roots.scm
@@ -31,10 +31,11 @@ (define %store #f)
 (test-begin "store-roots")
 
 (test-equal "gc-roots, initial"
-  (list (string-append %state-directory "/profiles"))
+  '()
   (begin
     ;; 'gc-roots' should gracefully handle lack of that directory.
-    (delete-file-recursively (string-append %state-directory "/profiles"))
+    (false-if-exception
+     (delete-file-recursively (string-append %state-directory "/profiles")))
     (gc-roots)))
 
 ;; The 'open-connection' call below gets guix-daemon to create
-- 
2.40.1

bug#64760: [PATCH 3/3] tests: texlive: Remove texlive-texworks from propagated-inputs.

[Josselin Poiret via Bug reports for GNU Guix]

From: Josselin Poiret <dev@jpoiret.xyz>

* tests/texlive.scm ("texlive->guix-package, meta-package"): Remove
texlive-texworks from expected propagated-inputs, as it is now ignored by
texlive->guix-package.
---
 tests/texlive.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/texlive.scm b/tests/texlive.scm
index 98461f7e51..b8b1d5c6d6 100644
--- a/tests/texlive.scm
+++ b/tests/texlive.scm
@@ -542,7 +542,7 @@ (define %fake-tlpdb
                ('arguments
                 ('list '#:builder ('gexp ('mkdir ('ungexp 'output)))))
                ('propagated-inputs
-                ('list 'texlive-collection-basic 'texlive-texworks))
+                ('list 'texlive-collection-basic))
                ('home-page "https://www.tug.org/texlive/")
                ('synopsis (? string?))
                ('description (? string?))
-- 
2.40.1

bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

[Janneke Nieuwenhuizen]

Josselin Poiret writes:

Hi Josselin,

>> Make check gives three failures for me on current master
>>
>>     FAIL: tests/packages     (package->bag)
>>     FAIL: tests/store-roots  (gc-roots, initial)  
>>     FAIL: tests/texlive      (texlive->guix-package, meta-package)
>>
>> using this snippet.
>
> I have local fixes for all of them

Nice!  I can confirm they work for me.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty.

[Janneke Nieuwenhuizen]

Josselin Poiret writes:

Hi!

> * tests/store-roots.scm ("gc-roots, initial"): Set expected result to empty.
> Also do not error out if /profiles doesn't exist.
> ---
>  tests/store-roots.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/store-roots.scm b/tests/store-roots.scm
> index 9877987a65..d82a29e313 100644
> --- a/tests/store-roots.scm
> +++ b/tests/store-roots.scm
> @@ -31,10 +31,11 @@ (define %store #f)
>  (test-begin "store-roots")
>  
>  (test-equal "gc-roots, initial"
> -  (list (string-append %state-directory "/profiles"))
> +  '()
>    (begin
>      ;; 'gc-roots' should gracefully handle lack of that directory.
> -    (delete-file-recursively (string-append %state-directory "/profiles"))
> +    (false-if-exception
> +     (delete-file-recursively (string-append %state-directory "/profiles")))
>      (gc-roots)))
>  
>  ;; The 'open-connection' call below gets guix-daemon to create

Just a headsup that this change breaks the store-roots test on the hurd
for me.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty.

[Janneke Nieuwenhuizen]

Janneke Nieuwenhuizen writes:

Hello,

> Josselin Poiret writes:
>
> Hi!
>
>> * tests/store-roots.scm ("gc-roots, initial"): Set expected result to empty.
>> Also do not error out if /profiles doesn't exist.
[..]
> Just a headsup that this change breaks the store-roots test on the hurd
> for me.

aaand as discussed on IRC, the missing output

--8<---------------cut here---------------start------------->8---
FAIL: tests/store-roots
=======================

test-name: gc-roots, initial
location: /tmp/guix-build-guix-1.4.0-8.5623ab5.drv-0/source/tests/store-roots.scm:33
source:
+ (test-equal
+   "gc-roots, initial"
+   '()
+   (begin
+     (false-if-exception
+       (delete-file-recursively
+         (string-append %state-directory "/profiles")))
+     (gc-roots)))
expected-value: ()
actual-value: ("/tmp/guix-tests/var/19337/profiles")
result: FAIL
--8<---------------cut here---------------end--------------->8---


-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty.

[Josselin Poiret via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

Hi everyone,

Janneke Nieuwenhuizen <janneke@gnu.org> writes:

> Just a headsup that this change breaks the store-roots test on the hurd
> for me.

Thanks for the feedback Janneke.  It seems that there is some left-over
state that can mess with this state's result: I was initially surprised
that the /profiles directory could appear in the gc roots, but that's
because it is symlinked under /gcroots, not because it is itself
searched for gc roots.

In any case, the /gcroots directory along with the /gcroots/profiles
symlink is created when a connection is made to the daemon, which is not
the case here yet.  However, a connection might have been opened before
for the same state dir (which depends on the PID of
build-aux/test-env.in).  It might also depend on whether the clean-up of
the state directory made by `trap` worked and whether PIDs get re-used
quickly on the specific kernel.  I think this is all too unreliable
here (I have one such example of a leftover PID state dir in my tree, so
it might happen more often than not).

In any case, if this test is only here to check if gc-roots doesn't
error out, we could return #t at the end to only fish for errors.  WDYT?

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

[Janneke Nieuwenhuizen]

Josselin Poiret writes:

Hey!

> Janneke Nieuwenhuizen <janneke@gnu.org> writes:
>
>> Just a headsup that this change breaks the store-roots test on the hurd
>> for me.
>
> Thanks for the feedback Janneke.  It seems that there is some left-over
> state that can mess with this state's result: I was initially surprised
> that the /profiles directory could appear in the gc roots, but that's
> because it is symlinked under /gcroots, not because it is itself
> searched for gc roots.
>
> In any case, the /gcroots directory along with the /gcroots/profiles
> symlink is created when a connection is made to the daemon, which is not
> the case here yet.  However, a connection might have been opened before
> for the same state dir (which depends on the PID of
> build-aux/test-env.in).  It might also depend on whether the clean-up of
> the state directory made by `trap` worked and whether PIDs get re-used
> quickly on the specific kernel.  I think this is all too unreliable
> here (I have one such example of a leftover PID state dir in my tree, so
> it might happen more often than not).

Yes, that could be.  I've got another data-point for i686-linux (see
also https://issues.guix.gnu.org/64959); the package and texlive tests
now pass, and store-roots is made to fail like so:

--8<---------------cut here---------------start------------->8---
test-name: gc-roots, initial
location: /home/janneke/src/guix/wip-i686/tests/store-roots.scm:33
source:
+ (test-equal
+   "gc-roots, initial"
+   '()
+   (begin
+     (false-if-exception
+       (delete-file-recursively
+         (string-append %state-directory "/profiles")))
+     (gc-roots)))
expected-value: ()
actual-value: ("/home/janneke/src/guix/wip-i686/test-tmp/var/30690/profiles")
result: FAIL
--8<---------------cut here---------------end--------------->8---

> In any case, if this test is only here to check if gc-roots doesn't
> error out, we could return #t at the end to only fish for errors.  WDYT?

(good question.../me passes insights here to "others" ;)

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

[Ludovic Courtès]

Hello!

Janneke Nieuwenhuizen <janneke@gnu.org> skribis:

> test-name: gc-roots, initial
> location: /home/janneke/src/guix/master/tests/store-roots.scm:33
> source:
> + (test-equal
> +   "gc-roots, initial"
> +   (list (string-append %state-directory "/profiles"))
> +   (begin
> +     (delete-file-recursively
> +       (string-append %state-directory "/profiles"))
> +     (gc-roots)))
> expected-value: ("/home/janneke/src/guix/master/test-tmp/var/9734/profiles")
> actual-value: #f
> actual-error:
> + (system-error
> +   "lstat"
> +   "~A: ~S"
> +   ("No such file or directory"
> +    "/home/janneke/src/guix/master/test-tmp/var/9734/profiles")
> +   (2))
> result: FAIL

Hmm, this test passes for me.

Could you get a backtrace so we see where the ‘lstat’ exception comes
from?  (To get the backtrace, you can raise (begin …) out of
‘test-equal’ and then “make check TESTS=tests/store-root.scm”.)

Thanks,
Ludo’.

bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

[Janneke Nieuwenhuizen]

Ludovic Courtès writes:

Hey!

> Janneke Nieuwenhuizen <janneke@gnu.org> skribis:
>
>> test-name: gc-roots, initial
>> location: /home/janneke/src/guix/master/tests/store-roots.scm:33
>> source:
>> + (test-equal
>> +   "gc-roots, initial"
>> +   (list (string-append %state-directory "/profiles"))
>> +   (begin
>> +     (delete-file-recursively
>> +       (string-append %state-directory "/profiles"))
>> +     (gc-roots)))
>> expected-value: ("/home/janneke/src/guix/master/test-tmp/var/9734/profiles")
>> actual-value: #f
>> actual-error:
>> + (system-error
>> +   "lstat"
>> +   "~A: ~S"
>> +   ("No such file or directory"
>> +    "/home/janneke/src/guix/master/test-tmp/var/9734/profiles")
>> +   (2))
>> result: FAIL
>
> Hmm, this test passes for me.

Well, what would you know, it passes for me too...

> Could you get a backtrace so we see where the ‘lstat’ exception comes
> from?  (To get the backtrace, you can raise (begin …) out of
> ‘test-equal’ and then “make check TESTS=tests/store-root.scm”.)

...as I found out after trying this.  I had my source tree configured
using --disable-daemon --disable-nls (a nifty feature that I encountered
only recently)...and then this (patched) test fails.  After
reconfiguring, all is well.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849

[Ludovic Courtès]

Hello!

Pushed as 4b1fdd44ed87dc07d23cc9313a8b6b14d0646923!

Ludo’.