From: Josselin Poiret via Bug reports for GNU Guix <bug-guix@gnu.org>
To: Janneke Nieuwenhuizen <janneke@gnu.org>
Cc: "Ludovic Courtès" <ludo@gnu.org>, 64760@debbugs.gnu.org
Subject: bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty.
Date: Fri, 28 Jul 2023 16:00:24 +0200 [thread overview]
Message-ID: <873518m8zr.fsf@jpoiret.xyz> (raw)
In-Reply-To: <87mszgcta7.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
Hi everyone,
Janneke Nieuwenhuizen <janneke@gnu.org> writes:
> Just a headsup that this change breaks the store-roots test on the hurd
> for me.
Thanks for the feedback Janneke. It seems that there is some left-over
state that can mess with this state's result: I was initially surprised
that the /profiles directory could appear in the gc roots, but that's
because it is symlinked under /gcroots, not because it is itself
searched for gc roots.
In any case, the /gcroots directory along with the /gcroots/profiles
symlink is created when a connection is made to the daemon, which is not
the case here yet. However, a connection might have been opened before
for the same state dir (which depends on the PID of
build-aux/test-env.in). It might also depend on whether the clean-up of
the state directory made by `trap` worked and whether PIDs get re-used
quickly on the specific kernel. I think this is all too unreliable
here (I have one such example of a leftover PID state dir in my tree, so
it might happen more often than not).
In any case, if this test is only here to check if gc-roots doesn't
error out, we could return #t at the end to only fish for errors. WDYT?
Best,
--
Josselin Poiret
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]
next prev parent reply other threads:[~2023-07-28 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 6:47 bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849 Janneke Nieuwenhuizen
2023-07-21 10:12 ` Josselin Poiret via Bug reports for GNU Guix
2023-07-21 10:14 ` bug#64760: [PATCH 1/3] tests: packages: Set system for expected result of package->bag Josselin Poiret via Bug reports for GNU Guix
2023-07-21 10:14 ` bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty Josselin Poiret via Bug reports for GNU Guix
2023-07-28 8:52 ` Janneke Nieuwenhuizen
2023-07-28 11:58 ` Janneke Nieuwenhuizen
2023-07-28 14:00 ` Josselin Poiret via Bug reports for GNU Guix [this message]
2023-07-30 16:19 ` bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849 Janneke Nieuwenhuizen
2023-07-21 10:14 ` bug#64760: [PATCH 3/3] tests: texlive: Remove texlive-texworks from propagated-inputs Josselin Poiret via Bug reports for GNU Guix
2023-08-18 14:13 ` bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849 Ludovic Courtès
2023-07-21 11:17 ` Janneke Nieuwenhuizen
2023-08-09 21:41 ` Ludovic Courtès
2023-08-11 12:31 ` Janneke Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873518m8zr.fsf@jpoiret.xyz \
--to=bug-guix@gnu.org \
--cc=64760@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=janneke@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).