unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Janneke Nieuwenhuizen <janneke@gnu.org>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: "Ludovic Courtès" <ludo@gnu.org>, 64760@debbugs.gnu.org
Subject: bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty.
Date: Fri, 28 Jul 2023 10:52:16 +0200	[thread overview]
Message-ID: <87mszgcta7.fsf@gnu.org> (raw)
In-Reply-To: <ad74949be91d909948d5539efad05e01556657b2.1689934453.git.dev@jpoiret.xyz> (Josselin Poiret's message of "Fri, 21 Jul 2023 12:14:58 +0200")

Josselin Poiret writes:

Hi!

> * tests/store-roots.scm ("gc-roots, initial"): Set expected result to empty.
> Also do not error out if /profiles doesn't exist.
> ---
>  tests/store-roots.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/store-roots.scm b/tests/store-roots.scm
> index 9877987a65..d82a29e313 100644
> --- a/tests/store-roots.scm
> +++ b/tests/store-roots.scm
> @@ -31,10 +31,11 @@ (define %store #f)
>  (test-begin "store-roots")
>  
>  (test-equal "gc-roots, initial"
> -  (list (string-append %state-directory "/profiles"))
> +  '()
>    (begin
>      ;; 'gc-roots' should gracefully handle lack of that directory.
> -    (delete-file-recursively (string-append %state-directory "/profiles"))
> +    (false-if-exception
> +     (delete-file-recursively (string-append %state-directory "/profiles")))
>      (gc-roots)))
>  
>  ;; The 'open-connection' call below gets guix-daemon to create

Just a headsup that this change breaks the store-roots test on the hurd
for me.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com




  reply	other threads:[~2023-07-28  9:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21  6:47 bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849 Janneke Nieuwenhuizen
2023-07-21 10:12 ` Josselin Poiret via Bug reports for GNU Guix
2023-07-21 10:14   ` bug#64760: [PATCH 1/3] tests: packages: Set system for expected result of package->bag Josselin Poiret via Bug reports for GNU Guix
2023-07-21 10:14   ` bug#64760: [PATCH 2/3] tests: store-roots: Initial gc-roots should be empty Josselin Poiret via Bug reports for GNU Guix
2023-07-28  8:52     ` Janneke Nieuwenhuizen [this message]
2023-07-28 11:58       ` Janneke Nieuwenhuizen
2023-07-28 14:00       ` Josselin Poiret via Bug reports for GNU Guix
2023-07-30 16:19         ` bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849 Janneke Nieuwenhuizen
2023-07-21 10:14   ` bug#64760: [PATCH 3/3] tests: texlive: Remove texlive-texworks from propagated-inputs Josselin Poiret via Bug reports for GNU Guix
2023-08-18 14:13     ` bug#64760: make check fails on 182be30fb1a8b847c30492462ec22c08ec7a9849 Ludovic Courtès
2023-07-21 11:17   ` Janneke Nieuwenhuizen
2023-08-09 21:41 ` Ludovic Courtès
2023-08-11 12:31   ` Janneke Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mszgcta7.fsf@gnu.org \
    --to=janneke@gnu.org \
    --cc=64760@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).