From: Simon Tournier <zimon.toutoune@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Ulf Herrman <striness@tilde.club>
Cc: dev@jpoiret.xyz, othacehe@gnu.org, ludo@gnu.org, me@tobias.gr,
65665@debbugs.gnu.org, rekado@elephly.net, guix@cbaines.net
Subject: bug#65665: [PATCH] Really get all the implicit inputs.
Date: Thu, 12 Oct 2023 16:22:43 +0200 [thread overview]
Message-ID: <86cyxj3op8.fsf@gmail.com> (raw)
In-Reply-To: <87a5swlbnp.fsf@gmail.com>
Hi Maxim,
On Thu, 05 Oct 2023 at 22:36, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> I've reviewed it, and it makes sense to me. I'd like to apply it to the
> core-updates branch. Core team, what say you?
Well, I am not sure to deeply understand some details to get all the
implications here, so I have nothing relevant to say. For instance,
from my understanding, the core change is:
--8<---------------cut here---------------start------------->8---
+ (define (rewrite-argument arg)
+ (match arg
+ ((? package? p)
+ (replace p))
+ ((? gexp-input? gi)
+ (gexp-input (rewrite-argument (gexp-input-thing gi))
+ (gexp-input-output gi)
+ #:native? (gexp-input-native? gi)))
+ ((? gexp? gxp)
+ (make-gexp (map rewrite-argument (gexp-references gxp))
+ (gexp-self-modules gxp)
+ (gexp-self-extensions gxp)
+ (gexp-proc gxp)
+ (%gexp-location gxp)))
+ ((lst ...)
+ (map rewrite-argument lst))
+ (_
+ arg)))
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
+ (arguments
+ (match p
+ (($ <package> _ _ _ _ args-proc)
+ ;; If we let ARGS-PROC be passed its original package,
+ ;; we somehow end up in an infinite (or maybe just
+ ;; exponential? Never seen it end...) loop. Should
+ ;; probably figure out what's causing that at some
+ ;; point.
+ (let ((args (args-proc this-package)))
+ (if deep?
+ (map rewrite-argument args)
+ args)))))
--8<---------------cut here---------------end--------------->8---
and I do not feel enough skilled here for getting the implications.
Equally for this kind of changes:
--8<---------------cut here---------------start------------->8---
- (arguments (strip-keyword-arguments private-keywords arguments)))))
+ (arguments
+ (substitute-keyword-arguments
+ (strip-keyword-arguments private-keywords arguments)
+ ((#:guile _ #t) guile))))))
--8<---------------cut here---------------end--------------->8---
Therefore, I trust other opinions or I need some time for diving and
filling some gaps.
Cheers,
simon
next prev parent reply other threads:[~2023-10-12 15:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 20:14 bug#65665: package-mapping with #:deep? #t doesn't get all the implicit inputs Ulf Herrman
2023-09-01 18:08 ` Csepp
2023-09-03 13:02 ` Maxim Cournoyer
2023-09-05 14:57 ` Simon Tournier
2023-09-16 9:45 ` bug#65665: [PATCH] Really " Ulf Herrman
2023-10-06 2:36 ` Maxim Cournoyer
2023-10-06 7:37 ` Ulf Herrman
2023-10-07 3:47 ` Ulf Herrman
2023-10-12 13:47 ` bug#65665: package-mapping with #:deep? #t doesn't " Ludovic Courtès
2023-10-12 7:07 ` bug#65665: [PATCH] Really " Ludovic Courtès
2023-10-12 14:22 ` Simon Tournier [this message]
2023-10-12 14:06 ` bug#65665: package-mapping with #:deep? #t doesn't " Ludovic Courtès
2023-10-12 16:00 ` Maxim Cournoyer
2023-10-14 14:47 ` Ludovic Courtès
2023-10-13 3:11 ` Ulf Herrman
2023-10-14 15:18 ` Ludovic Courtès
2023-10-15 7:12 ` Ulf Herrman
2023-10-21 14:31 ` Ludovic Courtès
2023-10-21 22:22 ` Ulf Herrman
2023-10-23 13:53 ` Simon Tournier
2023-10-12 13:53 ` Ludovic Courtès
2023-10-12 15:53 ` Maxim Cournoyer
2023-10-13 1:49 ` Ulf Herrman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cyxj3op8.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=65665@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=striness@tilde.club \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).