From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EBFPK0EPKGWTowAAG6o9tA:P1 (envelope-from ) for ; Thu, 12 Oct 2023 17:22:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EBFPK0EPKGWTowAAG6o9tA (envelope-from ) for ; Thu, 12 Oct 2023 17:22:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84F873ABDB for ; Thu, 12 Oct 2023 17:22:41 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=eD6VyLv7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697124161; a=rsa-sha256; cv=none; b=sXeaFi67AvSK7vE03Ag5o98b1wLhKOgaz/DRibSwdmcnMP0OM+AFp3GhaXN8puvgclqBVH i03RzxvSoU4cDJ2TU8ARhySyB3GayxhzyXVw5V3OD22dL6fcG2iEE45Op2MwKj5PMY9UDS 2LtyyeLOOcPne8GZrj5TwGzGnMK2OUoO/cI7ejLy6f9aOJlkOWMuP7FwBTPUK/H43k/K7y KCqdRetnoTVz5947stsIyKlbzhUElOEj6wV2g7kJUJMAyuCrANJIkgIi1993hT66R0mDaH sCOayw+DwS3MY8j6dPDyiLvk0TEuUevEGGOivJDsKHyuG3w4NEGEzUuVSe57fw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=eD6VyLv7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697124161; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rGP2rFnPAhv0g3ZKwsBNFrPMnIrLWbcaGO0QDdnmBVc=; b=htFgOTKF1Q/LoFzDxDPHysugWYvNAkQy4Hcq08m4WS7+RVxad8zh5/09kswOD9nx/+SIsG xb09uDAYmrdvxJ7Lf6dbALUZjYpPCsbewAzyp+D5MI4dH5AXliSxzG7xmFggq1TSTQmq6Y FhlOtPRCrmdvaT7AzD1/4oXUMun7fvaeBIGeZFKMQG8ps5c1N+JsdMS0j2qwBBOCtejcRD xiQxwnoSaGX+YVeGtAgjgH16y08jJ4tJAAd5pRCHW3upu8M1UsISlrGqkMSTlUco0pH7cE xuQMhz3OboF1Ibc6ZfP/1iKi4htCLJQp+T5U6Ct0Vvr2RSwZ/n2G9s1pSLr0Ow== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqwva-00010p-17; Thu, 12 Oct 2023 10:44:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqwvY-0000yd-4P for bug-guix@gnu.org; Thu, 12 Oct 2023 10:44:40 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqwvX-0006t2-Jo for bug-guix@gnu.org; Thu, 12 Oct 2023 10:44:39 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqwvu-00053N-01 for bug-guix@gnu.org; Thu, 12 Oct 2023 10:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65665: [PATCH] Really get all the implicit inputs. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 12 Oct 2023 14:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65665 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , Ulf Herrman Cc: dev@jpoiret.xyz, othacehe@gnu.org, ludo@gnu.org, me@tobias.gr, 65665@debbugs.gnu.org, rekado@elephly.net, guix@cbaines.net Received: via spool by 65665-submit@debbugs.gnu.org id=B65665.169712187119354 (code B ref 65665); Thu, 12 Oct 2023 14:45:01 +0000 Received: (at 65665) by debbugs.gnu.org; 12 Oct 2023 14:44:31 +0000 Received: from localhost ([127.0.0.1]:44055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqwvO-000526-Mw for submit@debbugs.gnu.org; Thu, 12 Oct 2023 10:44:31 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:41374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqwvI-00051a-HI for 65665@debbugs.gnu.org; Thu, 12 Oct 2023 10:44:26 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40651b22977so2660645e9.1 for <65665@debbugs.gnu.org>; Thu, 12 Oct 2023 07:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697121836; x=1697726636; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=rGP2rFnPAhv0g3ZKwsBNFrPMnIrLWbcaGO0QDdnmBVc=; b=eD6VyLv7AYSjtbEJj9/v8MuPk3c4Mzs4jGlCb8Gw/BJH75qXJ25aqbDlkT/5cySN3q ePE88S0o/3hgbeCqoeZdo2EXjIL4a23/ig0QUIn5optLLDj3G18ToYcr1dvRnzIfCMo1 0B0zQUJm3nYDBx+liHM1jzByX/2cQpTl3XSOKIO2I1SNuTsK53RChHjnWIF0KTd+n1qn AP6T/qkVLn66WKU/zvqn9P8OWtgmi8bkl3rDW4e54IkU12+PMsrQfDBYx/TbuPoxaq6x tp6kmhyEskSDDdv0oWv8gawkcR0OunOZ8fvOX/R77GakQMd71V+EYYfetldEGjkA794C l2Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697121836; x=1697726636; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rGP2rFnPAhv0g3ZKwsBNFrPMnIrLWbcaGO0QDdnmBVc=; b=Jmx8eSjI4WQhFdeFH3wWDJuTuXKHLk9vMj2DLBU/FWGCavNA1Prf3Etb70gYc5Lpxs ZoTZMr3MLfTiBb0HZtm0H/9nq0FM1YF4Y0q2kX1qzUnAcPh2kIHwn5FIKqznP59PHZtU D6SyqhmUxqzGx7dVvMXEmBWNFERTYxxdLS/2qhvQ77TaXmtlcxoKaFmcmMF3bBV+3A5b p478fx1ke1DJ7ZhC3f+38RCsUAxqguWZr+ACjyz2bg6BAvqeBrScurOsSL26aVv2e62q NrMDZa9WWQzQa1prNMNi7OOYk6PfTmtau02r75nrRgn1u/FC8eVnkfTJRJKzfaFy98rJ uVvQ== X-Gm-Message-State: AOJu0Yzl1Uua1+Ta8B9C/TwuXe6uYFJayKVMaaZxil22PTYsl6+BEFuW 3ixC3L4pCboH4+VXvvH6sxg= X-Google-Smtp-Source: AGHT+IGCrTXnRIhSaGfdluRYVsY4wP/Qzs9ngK31b3pP0AsUxDn4OXf43U5Qvr6DLEXHXOhTc0iLXQ== X-Received: by 2002:a05:600c:3b9a:b0:3fe:21a6:a18 with SMTP id n26-20020a05600c3b9a00b003fe21a60a18mr21800062wms.3.1697121836347; Thu, 12 Oct 2023 07:43:56 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c261300b00405442edc69sm21744wma.14.2023.10.12.07.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 07:43:56 -0700 (PDT) From: Simon Tournier In-Reply-To: <87a5swlbnp.fsf@gmail.com> References: <87h6ofufy5.fsf@tilde.club> <87msxmqwng.fsf@tilde.club> <87a5swlbnp.fsf@gmail.com> Date: Thu, 12 Oct 2023 16:22:43 +0200 Message-ID: <86cyxj3op8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: 4.29 X-Spam-Score: 4.29 X-Migadu-Queue-Id: 84F873ABDB X-TUID: 1S13p3WgmSTK Hi Maxim, On Thu, 05 Oct 2023 at 22:36, Maxim Cournoyer wrote: > I've reviewed it, and it makes sense to me. I'd like to apply it to the > core-updates branch. Core team, what say you? Well, I am not sure to deeply understand some details to get all the implications here, so I have nothing relevant to say. For instance, from my understanding, the core change is: --8<---------------cut here---------------start------------->8--- + (define (rewrite-argument arg) + (match arg + ((? package? p) + (replace p)) + ((? gexp-input? gi) + (gexp-input (rewrite-argument (gexp-input-thing gi)) + (gexp-input-output gi) + #:native? (gexp-input-native? gi))) + ((? gexp? gxp) + (make-gexp (map rewrite-argument (gexp-references gxp)) + (gexp-self-modules gxp) + (gexp-self-extensions gxp) + (gexp-proc gxp) + (%gexp-location gxp))) + ((lst ...) + (map rewrite-argument lst)) + (_ + arg))) --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- + (arguments + (match p + (($ _ _ _ _ args-proc) + ;; If we let ARGS-PROC be passed its original package, + ;; we somehow end up in an infinite (or maybe just + ;; exponential? Never seen it end...) loop. Should + ;; probably figure out what's causing that at some + ;; point. + (let ((args (args-proc this-package))) + (if deep? + (map rewrite-argument args) + args))))) --8<---------------cut here---------------end--------------->8--- and I do not feel enough skilled here for getting the implications. Equally for this kind of changes: --8<---------------cut here---------------start------------->8--- - (arguments (strip-keyword-arguments private-keywords arguments))))) + (arguments + (substitute-keyword-arguments + (strip-keyword-arguments private-keywords arguments) + ((#:guile _ #t) guile)))))) --8<---------------cut here---------------end--------------->8--- Therefore, I trust other opinions or I need some time for diving and filling some gaps. Cheers, simon