From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Ulf Herrman <striness@tilde.club>
Cc: dev@jpoiret.xyz, zimon.toutoune@gmail.com, othacehe@gnu.org,
ludo@gnu.org, me@tobias.gr, 65665@debbugs.gnu.org,
rekado@elephly.net, guix@cbaines.net
Subject: bug#65665: package-mapping with #:deep? #t doesn't get all the implicit inputs
Date: Sun, 03 Sep 2023 09:02:31 -0400 [thread overview]
Message-ID: <875y4rwgt4.fsf@gmail.com> (raw)
In-Reply-To: <87h6ofufy5.fsf@tilde.club> (Ulf Herrman's message of "Thu, 31 Aug 2023 15:14:58 -0500")
Hello Ulf,
Ulf Herrman <striness@tilde.club> writes:
> #:deep? #t currently works by interposing a dummy build system that
> lowers the package to a bag using the original build system, then
> applies the supplied transformation to all of the bag's inputs, then
> returns a new bag with the new inputs.
>
> The problem with this approach is that it doesn't affect the bag
> arguments. This means that packages passed in as arguments may still
> end up being used without being transformed. Worse still, packages
> *not* passed in as arguments may end up being used *unless one is
> explicitly passed in as an argument*, as is the case with
> qt-build-system's #:qtbase argument.
>
> In short, the current approach of having the build-system lower
> procedure leave the arguments mostly unchanged and letting the
> bag->derivation procedure (the "bag builder") fill in lots of defaults
> means that there are implicit inputs that cannot be touched at the
> package level without adding special logic for every single build system
> that does something like this.
This is indeed sub-optimal!
> I propose that we have the build system lower procedure (that is, the
> one that converts from package to bag) completely fill in the argument
> list with all defaults, and we modify build-system-with-package-mapping
> to transform all arguments that look like a package or a list of
> packages (or maybe even a tree containing packages).
[...]
> What do you think?
Like Csepp, I like your proposition! I'm CC'ing the core team, in case
they have something to add to it, but otherwise, we only need a
volunteer to turn it into code :-).
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-09-03 13:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 20:14 bug#65665: package-mapping with #:deep? #t doesn't get all the implicit inputs Ulf Herrman
2023-09-01 18:08 ` Csepp
2023-09-03 13:02 ` Maxim Cournoyer [this message]
2023-09-05 14:57 ` Simon Tournier
2023-09-16 9:45 ` bug#65665: [PATCH] Really " Ulf Herrman
2023-10-06 2:36 ` Maxim Cournoyer
2023-10-06 7:37 ` Ulf Herrman
2023-10-07 3:47 ` Ulf Herrman
2023-10-12 13:47 ` bug#65665: package-mapping with #:deep? #t doesn't " Ludovic Courtès
2023-10-12 7:07 ` bug#65665: [PATCH] Really " Ludovic Courtès
2023-10-12 14:22 ` Simon Tournier
2023-10-12 14:06 ` bug#65665: package-mapping with #:deep? #t doesn't " Ludovic Courtès
2023-10-12 16:00 ` Maxim Cournoyer
2023-10-14 14:47 ` Ludovic Courtès
2023-10-13 3:11 ` Ulf Herrman
2023-10-14 15:18 ` Ludovic Courtès
2023-10-15 7:12 ` Ulf Herrman
2023-10-21 14:31 ` Ludovic Courtès
2023-10-21 22:22 ` Ulf Herrman
2023-10-23 13:53 ` Simon Tournier
2023-10-12 13:53 ` Ludovic Courtès
2023-10-12 15:53 ` Maxim Cournoyer
2023-10-13 1:49 ` Ulf Herrman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y4rwgt4.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=65665@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=striness@tilde.club \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).