* bug#45494: f2fs-tools-static doesn't find uuid.h @ 2020-12-27 16:11 raingloom 2020-12-28 14:03 ` Danny Milosavljevic 0 siblings, 1 reply; 2+ messages in thread From: raingloom @ 2020-12-27 16:11 UTC (permalink / raw) To: 45494 According to `git bisect` (which I used for the first time today, so i might be wrong) the recent f2fs-tools upgrade broke f2fs-tools-static. I tried debugging it a bit today and so far didn't run across any obvious causes. I'll take a look again soon-ish. ^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#45494: f2fs-tools-static doesn't find uuid.h 2020-12-27 16:11 bug#45494: f2fs-tools-static doesn't find uuid.h raingloom @ 2020-12-28 14:03 ` Danny Milosavljevic 0 siblings, 0 replies; 2+ messages in thread From: Danny Milosavljevic @ 2020-12-28 14:03 UTC (permalink / raw) To: raingloom; +Cc: 45494-done [-- Attachment #1: Type: text/plain, Size: 1781 bytes --] Hi, thanks for the report! fixed in guix master commit a099d833af3afe69c50dbd016e9ed117462ca7ef. Analysis: According to https://linux.die.net/man/3/uuid users of the uuid lib should do: >#include <uuid/uuid.h> however, "man uuid" in Guix says to do (that's from util-linux-2.35.1/libuuid/man/uuid.3) > #include <uuid.h> and f2fs-tools does (in mkfs/f2fs_format_main.c:21): > #include <uuid.h> I've also checked their git repository at https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/tree/mkfs/f2fs_format_main.c and they still do: > #include <uuid.h> Then I tried guix environment --pure f2fs-tools-static --ad-hoc gcc-toolchain and we have: echo $C_INCLUDE_PATH >/gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include But /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include/uuid.h does not exist. But /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include/uuid/uuid.h does exist. cat /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/lib/pkgconfig/uuid.pc >Cflags: -I${includedir}/uuid So I'd say that pkg-config is missing. And indeed I had already worked around that in gnu/packages/linux.scm : >#:configure-flags > (let ((libuuid-static (assoc-ref %build-inputs "libuuid:static")) > (libuuid (assoc-ref %build-inputs "libuuid"))) > (list > (string-append "libuuid_CFLAGS=-I" libuuid "/include") Here, suffix "/uuid" is missing. > (string-append "libuuid_LIBS=-L" libuuid-static "/lib -luuid") > (string-append "libblkid_CFLAGS=-I" libuuid "/include") Here, suffix "/uuid" is missing. Similarly for "/blkid". > (string-append "libblkid_LIBS=-L" libuuid-static "/lib -lblkid") Ok [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-28 14:04 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-27 16:11 bug#45494: f2fs-tools-static doesn't find uuid.h raingloom 2020-12-28 14:03 ` Danny Milosavljevic
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).