From: Danny Milosavljevic <dannym@scratchpost.org>
To: raingloom <raingloom@riseup.net>
Cc: 45494-done@debbugs.gnu.org
Subject: bug#45494: f2fs-tools-static doesn't find uuid.h
Date: Mon, 28 Dec 2020 15:03:50 +0100 [thread overview]
Message-ID: <20201228150350.00e02d8c@scratchpost.org> (raw)
In-Reply-To: <20201227171145.749a3313@riseup.net>
[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]
Hi,
thanks for the report!
fixed in guix master commit a099d833af3afe69c50dbd016e9ed117462ca7ef.
Analysis:
According to https://linux.die.net/man/3/uuid users of the uuid lib should do:
>#include <uuid/uuid.h>
however, "man uuid" in Guix says to do
(that's from util-linux-2.35.1/libuuid/man/uuid.3)
> #include <uuid.h>
and f2fs-tools does (in mkfs/f2fs_format_main.c:21):
> #include <uuid.h>
I've also checked their git repository at
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/tree/mkfs/f2fs_format_main.c
and they still do:
> #include <uuid.h>
Then I tried
guix environment --pure f2fs-tools-static --ad-hoc gcc-toolchain
and we have:
echo $C_INCLUDE_PATH
>/gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include
But /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include/uuid.h does not exist.
But /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/include/uuid/uuid.h does exist.
cat /gnu/store/w6266wwyy7ih2p22g8k4fzx7a1dj61qn-profile/lib/pkgconfig/uuid.pc
>Cflags: -I${includedir}/uuid
So I'd say that pkg-config is missing.
And indeed I had already worked around that in gnu/packages/linux.scm :
>#:configure-flags
> (let ((libuuid-static (assoc-ref %build-inputs "libuuid:static"))
> (libuuid (assoc-ref %build-inputs "libuuid")))
> (list
> (string-append "libuuid_CFLAGS=-I" libuuid "/include")
Here, suffix "/uuid" is missing.
> (string-append "libuuid_LIBS=-L" libuuid-static "/lib -luuid")
> (string-append "libblkid_CFLAGS=-I" libuuid "/include")
Here, suffix "/uuid" is missing.
Similarly for "/blkid".
> (string-append "libblkid_LIBS=-L" libuuid-static "/lib -lblkid")
Ok
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-12-28 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 16:11 bug#45494: f2fs-tools-static doesn't find uuid.h raingloom
2020-12-28 14:03 ` Danny Milosavljevic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228150350.00e02d8c@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=45494-done@debbugs.gnu.org \
--cc=raingloom@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).