From: Danny Milosavljevic <dannym@scratchpost.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: 35068@debbugs.gnu.org
Subject: bug#35068: GDM crashes when it cannot find any .desktop files
Date: Thu, 25 Apr 2019 21:15:40 +0200 [thread overview]
Message-ID: <20190425211540.3ecda900@scratchpost.org> (raw)
In-Reply-To: <87tvel7we1.fsf@ngyro.com>
[-- Attachment #1: Type: text/plain, Size: 2204 bytes --]
Hi Timothy,
On Thu, 25 Apr 2019 14:49:42 -0400
Timothy Sample <samplet@ngyro.com> wrote:
> exploding. I did look at Danny’s patch (#35377), and it would work, but
> it seems a little arbitrary. Nothing understands the “Exec=custom”
> line, and our “xinitrc” runs “~/.xsession” regardless of what desktop
> entry is selected in the DM.
gdm does know it. It bundles gdm Xsession startup scripts and then runs
".xsession" (see data/Xsession.in) if available, otherwise ~/.Xclients.
> There are two workarounds. The first is to keep Danny’s patch as-is,
> but add logic to “xinitrc” so that it only uses “~/.xsession” when
.xinitrc is not picked up by gdm. Do you mean by startx?
> break other DMs that don’t install a “custom.desktop”. Maybe we could
> integrate it into all DMs at the service level.
Well, the best way would be for gdm to support .xsession files like anyone
else (without desktop file)--but I'm not holding my breath.
> This way, GDM fails cleanly when there are no “.desktop” files. It
> doesn’t show up in the list, either (“NoDisplay=true”), so everything
> just kinda works as expected without any visible changes.
I want it to show up in the list. Maybe we are trying to reach different
goals here. I have a ~/.xsession script for close to a decade now and I
want gdm to use it. It's not only to keep gdm from crashing, it's so I
can get into my normal customized desktop.
Doesn't Exec=false make the login fail? Or do you mean gdm will pick up
.xsession anyway and run it--and after the session is terminated, the
login will fail? Why would it then fail? Why not make it succeed?
> Danny, maybe you could adjust your patch to follow the second option and
> apply it for the sake of everyone else who’s system profile doesn’t have
> any “.desktop” files. It might save people headaches in the short-term
> regardless of what we settle on as a final solution.
Sounds good in principle, as long as it actually allows me to log in to
my desktop.
FWIW, "Exec=custom" is the way gdm itself does it.
Still, ~/.xinitrc is not picked up either way--which is too bad.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-25 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 8:05 bug#35068: GDM crashes when it cannot find any .desktop files Ludovic Courtès
2019-04-20 15:06 ` Danny Milosavljevic
2019-04-20 20:22 ` Ludovic Courtès
2019-04-21 9:37 ` Danny Milosavljevic
2019-04-21 9:43 ` Danny Milosavljevic
2019-04-21 20:12 ` Ludovic Courtès
2019-04-25 18:49 ` Timothy Sample
2019-04-25 19:15 ` Danny Milosavljevic [this message]
2019-04-26 1:02 ` Timothy Sample
2019-04-26 9:36 ` Danny Milosavljevic
2019-04-26 8:10 ` Ludovic Courtès
2019-04-26 18:32 ` Timothy Sample
2019-04-27 16:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425211540.3ecda900@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=35068@debbugs.gnu.org \
--cc=samplet@ngyro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).