unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: 35068@debbugs.gnu.org
Subject: bug#35068: GDM crashes when it cannot find any .desktop files
Date: Sun, 21 Apr 2019 11:37:49 +0200	[thread overview]
Message-ID: <20190421113749.0439cbc9@scratchpost.org> (raw)
In-Reply-To: <20190420170649.30c05dbd@scratchpost.org>

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

Further investigation:

diff -ru orig/gdm-3.26.2.1/daemon/gdm-session.c gdm-3.26.2.1/daemon/gdm-session.c
--- orig/gdm-3.26.2.1/daemon/gdm-session.c      1970-01-01 01:00:00.000000000 +0100
+++ gdm-3.26.2.1/daemon/gdm-session.c   2019-04-21 10:58:31.211164558 +0200
@@ -2483,6 +2483,10 @@
                                       const char *value)
 {
         g_return_if_fail (key != NULL);
+        if (value == NULL) {
+                g_warning ("XXX gdm: value == NULL for key == %s", key);
+                value = "";
+        }
         g_return_if_fail (value != NULL);
 
         g_hash_table_replace (self->priv->environment,

Yields:

Apr 21 11:23:57 localhost gdm: XXX gdm: value == NULL for key == PATH 
Apr 21 11:23:57 localhost gdm: Child process -1384 was already dead. 
Apr 21 11:23:57 localhost gdm: Child process 1381 was already dead. 
Apr 21 11:23:57 localhost gdm: Unable to kill session worker process 

and endless loop.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2019-04-21  9:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01  8:05 bug#35068: GDM crashes when it cannot find any .desktop files Ludovic Courtès
2019-04-20 15:06 ` Danny Milosavljevic
2019-04-20 20:22   ` Ludovic Courtès
2019-04-21  9:37   ` Danny Milosavljevic [this message]
2019-04-21  9:43     ` Danny Milosavljevic
2019-04-21 20:12     ` Ludovic Courtès
2019-04-25 18:49       ` Timothy Sample
2019-04-25 19:15         ` Danny Milosavljevic
2019-04-26  1:02           ` Timothy Sample
2019-04-26  9:36             ` Danny Milosavljevic
2019-04-26  8:10         ` Ludovic Courtès
2019-04-26 18:32           ` Timothy Sample
2019-04-27 16:27             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190421113749.0439cbc9@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=35068@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).