From: Danny Milosavljevic <dannym@scratchpost.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: 35068@debbugs.gnu.org
Subject: bug#35068: GDM crashes when it cannot find any .desktop files
Date: Fri, 26 Apr 2019 11:36:03 +0200 [thread overview]
Message-ID: <20190426113603.5412fdc7@scratchpost.org> (raw)
In-Reply-To: <87pnp97f42.fsf@ngyro.com>
[-- Attachment #1: Type: text/plain, Size: 3025 bytes --]
Hi Timothy,
On Thu, 25 Apr 2019 21:02:53 -0400
Timothy Sample <samplet@ngyro.com> wrote:
> Furthermore (I was surprised by this), even though the
> “data/Xsession.in” script says that it will honour “custom” in a
> comment, the code says otherwise. There’s a commit where support for it
> gets removed, but they must have forgotten about the comment.
> We don’t need a “.desktop” file currently. My personal opinion is that
> having the existence of the “~/.xsession” script override your
> explicitly stated session selection when logging in is a little
> surprising. But if that’s conventional, then I’m happy to follow
> convention.
I don't know what's conventional here.
But a CUSTOM session is just that:
A customer customized their session and presumably wants to enter that
customized session. However, he should still be able to enter other
sessions by selecting a non-customized session in the DM.
If I wrote a DM, I'd scan for desktop files, add those to the session selection
menu, then scan for the file "~/.xsession" and, if that exists, add a
"custom" entry to the session selection menu.
The session that had been selected previously for that user should be the
default for that user the next time--unless he changes the selection again.
The first time a ~/.xsession shows up, the session manager should select it
(or ask).
In any case, let's just make gdm not crash and do a minimally invasive fix.
We are not upstream and they can clean up their own mess.
> >> This way, GDM fails cleanly when there are no “.desktop” files. It
> >> doesn’t show up in the list, either (“NoDisplay=true”), so everything
> >> just kinda works as expected without any visible changes.
Nice!
> Currently, our “xinitrc” script will run your “~/.xsession” script if it
> exists, regardless of what session you select when logging in.
Hmm, that's not what I thought it would do. We could change it...
> However, GDM will crash if you do not have any “.desktop” files.
Yeah, there are a lot of places where it assumes that desktop files
have been read. Even the "fallback" case requires desktop files.
> With
> the dummy file, if you have a “~/.xsession” script, you will be able to
> log in even if you have no other “.desktop” files. If you have no
> “.desktop” files and no “~/.xsession” script, logging in will fail
> (which seems reasonable, seeing how desperate the circumstances are).
That's fair.
> > Still, ~/.xinitrc is not picked up either way--which is too bad.
>
> Isn’t that script specific to “startx”? (That’s at least what a popular
> question and answer site tells me.)
Yes, I had it from the time I still used startx.
So I guess it's okay if .xinitrc isn't used by gdm.
It would still be nice if .xsession was only used for the "custom session"
choice, which is what I wanted it to do. I guess we could also adapt
our xinitrc script.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-26 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 8:05 bug#35068: GDM crashes when it cannot find any .desktop files Ludovic Courtès
2019-04-20 15:06 ` Danny Milosavljevic
2019-04-20 20:22 ` Ludovic Courtès
2019-04-21 9:37 ` Danny Milosavljevic
2019-04-21 9:43 ` Danny Milosavljevic
2019-04-21 20:12 ` Ludovic Courtès
2019-04-25 18:49 ` Timothy Sample
2019-04-25 19:15 ` Danny Milosavljevic
2019-04-26 1:02 ` Timothy Sample
2019-04-26 9:36 ` Danny Milosavljevic [this message]
2019-04-26 8:10 ` Ludovic Courtès
2019-04-26 18:32 ` Timothy Sample
2019-04-27 16:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426113603.5412fdc7@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=35068@debbugs.gnu.org \
--cc=samplet@ngyro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).