From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: bug#35068: GDM crashes when it cannot find any .desktop files Date: Thu, 25 Apr 2019 21:15:40 +0200 Message-ID: <20190425211540.3ecda900@scratchpost.org> References: <87lg0um9qb.fsf@gnu.org> <20190420170649.30c05dbd@scratchpost.org> <20190421113749.0439cbc9@scratchpost.org> <87v9z72k3p.fsf@gnu.org> <87tvel7we1.fsf@ngyro.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/_H_ZcYogOo.vBkVKTVJ7pYO"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:59889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJk1w-0005YY-5g for bug-guix@gnu.org; Thu, 25 Apr 2019 15:27:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJjql-0003El-St for bug-guix@gnu.org; Thu, 25 Apr 2019 15:16:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45827) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJjqk-0003B2-W4 for bug-guix@gnu.org; Thu, 25 Apr 2019 15:16:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJjqk-0005RM-Jg for bug-guix@gnu.org; Thu, 25 Apr 2019 15:16:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87tvel7we1.fsf@ngyro.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Timothy Sample Cc: 35068@debbugs.gnu.org --Sig_/_H_ZcYogOo.vBkVKTVJ7pYO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Timothy, On Thu, 25 Apr 2019 14:49:42 -0400 Timothy Sample wrote: > exploding. I did look at Danny=E2=80=99s patch (#35377), and it would wo= rk, but > it seems a little arbitrary. Nothing understands the =E2=80=9CExec=3Dcus= tom=E2=80=9D > line, and our =E2=80=9Cxinitrc=E2=80=9D runs =E2=80=9C~/.xsession=E2=80= =9D regardless of what desktop > entry is selected in the DM. gdm does know it. It bundles gdm Xsession startup scripts and then runs ".xsession" (see data/Xsession.in) if available, otherwise ~/.Xclients. > There are two workarounds. The first is to keep Danny=E2=80=99s patch as= -is, > but add logic to =E2=80=9Cxinitrc=E2=80=9D so that it only uses =E2=80=9C= ~/.xsession=E2=80=9D when .xinitrc is not picked up by gdm. Do you mean by startx? > break other DMs that don=E2=80=99t install a =E2=80=9Ccustom.desktop=E2= =80=9D. Maybe we could > integrate it into all DMs at the service level. Well, the best way would be for gdm to support .xsession files like anyone else (without desktop file)--but I'm not holding my breath. =20 > This way, GDM fails cleanly when there are no =E2=80=9C.desktop=E2=80=9D = files. It > doesn=E2=80=99t show up in the list, either (=E2=80=9CNoDisplay=3Dtrue=E2= =80=9D), so everything > just kinda works as expected without any visible changes. I want it to show up in the list. Maybe we are trying to reach different goals here. I have a ~/.xsession script for close to a decade now and I want gdm to use it. It's not only to keep gdm from crashing, it's so I can get into my normal customized desktop. Doesn't Exec=3Dfalse make the login fail? Or do you mean gdm will pick up .xsession anyway and run it--and after the session is terminated, the login will fail? Why would it then fail? Why not make it succeed? > Danny, maybe you could adjust your patch to follow the second option and > apply it for the sake of everyone else who=E2=80=99s system profile doesn= =E2=80=99t have > any =E2=80=9C.desktop=E2=80=9D files. It might save people headaches in = the short-term > regardless of what we settle on as a final solution. Sounds good in principle, as long as it actually allows me to log in to my desktop. FWIW, "Exec=3Dcustom" is the way gdm itself does it. Still, ~/.xinitrc is not picked up either way--which is too bad. --Sig_/_H_ZcYogOo.vBkVKTVJ7pYO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlzCB1wACgkQ5xo1VCww uqX/Rwf9Fybz3ehmgjbIL+Hn+Kx7tmq9IhX4xQQlHdFq/P5YuvfKGoNTkUImS7As G6viajMFuCQDweYCma6FmjKsAk5M7K2FjQ5hAA52vHOPdgQsMhNs5Mf6qGsWlXDC 5gg45eUCigG3Re4Zx2ORVuNNJZhrgJnVPsV5XA2R010A4kV5sj89jFTN1q4ncmhT Fu1VyGJ0JDzfhxJPpUKL4TbADztaeP4lIdhGoTAczwe282uVeGRmUD3jTXf1Ae3j wAMV6G0ABg+ruwFMRd9aRUH4hLDEs7dkk1IC0Xm33Dy90th45SAshsf9Ut76GiKR qBVkPLsybeOGF/bxE5yWV7zJLy/Q5Q== =gvDX -----END PGP SIGNATURE----- --Sig_/_H_ZcYogOo.vBkVKTVJ7pYO--