unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
* [PATCH] eval-string: Fix setting port column
@ 2024-03-14 11:11 Nikita Domnitskii
  2024-03-20 20:12 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
  2024-04-05 23:09 ` Rob Browning
  0 siblings, 2 replies; 4+ messages in thread
From: Nikita Domnitskii @ 2024-03-14 11:11 UTC (permalink / raw)
  To: guile-devel

---
 module/ice-9/eval-string.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
index ea0f17777..9cac03632 100644
--- a/module/ice-9/eval-string.scm
+++ b/module/ice-9/eval-string.scm
@@ -81,7 +81,7 @@
           (if line
               (set-port-line! port line))
           (if column
-              (set-port-column! port line))
+              (set-port-column! port column))
 
           (if (or compile? (not (language-evaluator lang)))
               ((load-thunk-from-memory


-- 
Best Regards,
Nikita Domnitskii



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] eval-string: Fix setting port column
  2024-03-14 11:11 [PATCH] eval-string: Fix setting port column Nikita Domnitskii
@ 2024-03-20 20:12 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
  2024-05-06  9:38   ` bug#69921: " Ludovic Courtès
  2024-04-05 23:09 ` Rob Browning
  1 sibling, 1 reply; 4+ messages in thread
From: Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library @ 2024-03-20 20:12 UTC (permalink / raw)
  To: Nikita Domnitskii, guile-devel; +Cc: bug-guile

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
> ---
>  module/ice-9/eval-string.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f17777..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
>            (if line
>                (set-port-line! port line))
>            (if column
> -              (set-port-column! port line))
> +              (set-port-column! port column))
>  
>            (if (or compile? (not (language-evaluator lang)))
>                ((load-thunk-from-memory
> 
> 

LGTM (wrong since 2011, it seems), but needs somebody with commit
access to push.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] eval-string: Fix setting port column
  2024-03-14 11:11 [PATCH] eval-string: Fix setting port column Nikita Domnitskii
  2024-03-20 20:12 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
@ 2024-04-05 23:09 ` Rob Browning
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Browning @ 2024-04-05 23:09 UTC (permalink / raw)
  To: Nikita Domnitskii, guile-devel

Nikita Domnitskii <nikita@domnitskii.me> writes:

> ---
>  module/ice-9/eval-string.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f17777..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
>            (if line
>                (set-port-line! port line))
>            (if column
> -              (set-port-column! port line))
> +              (set-port-column! port column))
>  
>            (if (or compile? (not (language-evaluator lang)))
>                ((load-thunk-from-memory

Thanks - added a test and pushed to main.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bug#69921: [PATCH] eval-string: Fix setting port column
  2024-03-20 20:12 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
@ 2024-05-06  9:38   ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2024-05-06  9:38 UTC (permalink / raw)
  To: Jonas Hahnfeld; +Cc: Nikita Domnitskii, guile-devel, 69921-done

Jonas Hahnfeld <hahnjo@hahnjo.de> skribis:

> On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
>> ---
>>  module/ice-9/eval-string.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
>> index ea0f17777..9cac03632 100644
>> --- a/module/ice-9/eval-string.scm
>> +++ b/module/ice-9/eval-string.scm
>> @@ -81,7 +81,7 @@
>>            (if line
>>                (set-port-line! port line))
>>            (if column
>> -              (set-port-column! port line))
>> +              (set-port-column! port column))
>>  
>>            (if (or compile? (not (language-evaluator lang)))
>>                ((load-thunk-from-memory
>> 
>> 
>
> LGTM (wrong since 2011, it seems), but needs somebody with commit
> access to push.

This was pushed as 025bb024ae4b586dc721e3d2e3471fbea5f8cc81.

Closing!

Ludo’.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-05-06  9:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-14 11:11 [PATCH] eval-string: Fix setting port column Nikita Domnitskii
2024-03-20 20:12 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-05-06  9:38   ` bug#69921: " Ludovic Courtès
2024-04-05 23:09 ` Rob Browning

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).