From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Newsgroups: gmane.lisp.guile.devel Subject: Re: bug#69921: [PATCH] eval-string: Fix setting port column Date: Mon, 06 May 2024 11:38:35 +0200 Message-ID: <87zft3l1pg.fsf@gnu.org> References: <871q8d131g.fsf@asgard.mail-host-address-is-not-set> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14222"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Nikita Domnitskii , guile-devel@gnu.org, 69921-done@debbugs.gnu.org To: Jonas Hahnfeld Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Mon May 06 11:39:23 2024 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3uod-0003OO-1M for guile-devel@m.gmane-mx.org; Mon, 06 May 2024 11:39:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3uo0-0002KW-Qt; Mon, 06 May 2024 05:38:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3unz-0002K5-Dp for guile-devel@gnu.org; Mon, 06 May 2024 05:38:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3uny-00088F-EO; Mon, 06 May 2024 05:38:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=XINz0ndObLBDtaAKfjjuH1p7QxEUaiweCzhTu6etaZE=; b=Yp2QiBR16HDzCAMXnWoQ DVGl+lo4Nbrl2ynnqMYgaSkqLNWny3VcpncDzYCzQHO+LLRBuUqcj3L17d585Gq5EANHaRr1m65u2 6PNVZicYd4KCL+I33SNaYlnC+yHlLUo/qamxYDIscjL1vXMwjO+i5XjV1JxOeqIe9+tXYLxv0pz62 vMIfPQMI40P9X4rt71OfYEcQ4eQoGSmyPolNzVFSasg0VTSP/JUwdlgLt7oq/GX41dyG+OC1vptpn +JOhI1VqjMChVgWvh+kxCqtpQ9fRPiz0Uvis5UebTdARQljB3Iefuct5x8QBCB5BfpyXh869nMzh8 10uElzn7AfTe2Q==; In-Reply-To: (Jonas Hahnfeld's message of "Wed, 20 Mar 2024 21:12:52 +0100") X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22413 Archived-At: Jonas Hahnfeld skribis: > On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote: >> --- >> module/ice-9/eval-string.scm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm >> index ea0f17777..9cac03632 100644 >> --- a/module/ice-9/eval-string.scm >> +++ b/module/ice-9/eval-string.scm >> @@ -81,7 +81,7 @@ >> (if line >> (set-port-line! port line)) >> (if column >> - (set-port-column! port line)) >> + (set-port-column! port column)) >>=20=20 >> (if (or compile? (not (language-evaluator lang))) >> ((load-thunk-from-memory >>=20 >>=20 > > LGTM (wrong since 2011, it seems), but needs somebody with commit > access to push. This was pushed as 025bb024ae4b586dc721e3d2e3471fbea5f8cc81. Closing! Ludo=E2=80=99.