From: Jonas Hahnfeld via "Developers list for Guile, the GNU extensibility library" <guile-devel@gnu.org>
To: Nikita Domnitskii <nikita@domnitskii.me>, guile-devel@gnu.org
Cc: bug-guile@gnu.org
Subject: Re: [PATCH] eval-string: Fix setting port column
Date: Wed, 20 Mar 2024 21:12:52 +0100 [thread overview]
Message-ID: <ac59e47a4f0d39c92097999283bbb09a55ecc508.camel@hahnjo.de> (raw)
In-Reply-To: <871q8d131g.fsf@asgard.mail-host-address-is-not-set>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
> ---
> module/ice-9/eval-string.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f17777..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
> (if line
> (set-port-line! port line))
> (if column
> - (set-port-column! port line))
> + (set-port-column! port column))
>
> (if (or compile? (not (language-evaluator lang)))
> ((load-thunk-from-memory
>
>
LGTM (wrong since 2011, it seems), but needs somebody with commit
access to push.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-20 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 11:11 [PATCH] eval-string: Fix setting port column Nikita Domnitskii
2024-03-20 20:12 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library [this message]
2024-04-05 23:09 ` Rob Browning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac59e47a4f0d39c92097999283bbb09a55ecc508.camel@hahnjo.de \
--to=guile-devel@gnu.org \
--cc=bug-guile@gnu.org \
--cc=hahnjo@hahnjo.de \
--cc=nikita@domnitskii.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).