unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Omar Polo <op@omarpolo.com>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] test-system-cmds: use sh -c instead of guile -c
Date: Sat, 28 Jan 2023 17:43:42 +0200	[thread overview]
Message-ID: <83bkmiaclt.fsf@gnu.org> (raw)
In-Reply-To: <2PWE9J0AYIN1N.3GXGS3S39YKS3@venera> (message from Omar Polo on Sat, 28 Jan 2023 11:17:07 +0100)

> Date: Sat, 28 Jan 2023 11:17:07 +0100
> From: Omar Polo <op@omarpolo.com>
> 
> I'm not sure this patch is palatable as-is, but I'm adding it to the
> OpenBSD port to have less failures in the regress suite.
> 
> The main issue is that "guile" may not be available at test time for
> various reasons.  (the install prefix is not in $PATH, the executable
> may be renamed --program-suffix, etc...)

the intent of the test is to test the just-produced Guile binary, so
if that binary is not on PATH, the test suite should be fixed so that
it is on PATH.

> The comment about windows however makes me think that neither sh may
> be available.  Using meta/guile then is better, other tests are doing
> that, but I haven't found the right incantation to do so.

I'm responsible for that comment, so when I ran the test suite, it did
find the Guile binary in the build tree.  Maybe something happened in
the meantime that it doesn't now, but the right fix is IMO definitely
not to replace Guile with sh, as relying on sh being available is not
going to work on Windows.

Please instead try to figure out why guile is not on PATH.  Running
meta/guile might be better, but isn't that a shell script that
requires sh as well?



  reply	other threads:[~2023-01-28 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28 10:17 [PATCH] test-system-cmds: use sh -c instead of guile -c Omar Polo
2023-01-28 15:43 ` Eli Zaretskii [this message]
2023-01-30 15:44   ` Omar Polo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkmiaclt.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=op@omarpolo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).