unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Omar Polo <op@omarpolo.com>
To: guile-devel@gnu.org
Subject: [PATCH] test-system-cmds: use sh -c instead of guile -c
Date: Sat, 28 Jan 2023 11:17:07 +0100	[thread overview]
Message-ID: <2PWE9J0AYIN1N.3GXGS3S39YKS3@venera> (raw)

Hello,

I'm not sure this patch is palatable as-is, but I'm adding it to the
OpenBSD port to have less failures in the regress suite.

The main issue is that "guile" may not be available at test time for
various reasons.  (the install prefix is not in $PATH, the executable
may be renamed --program-suffix, etc...)

The comment about windows however makes me think that neither sh may
be available.  Using meta/guile then is better, other tests are doing
that, but I haven't found the right incantation to do so.


Thanks,

Omar Polo

From 177f7dfa68ff47d448c7a8ac0cb4834eefef8dce Mon Sep 17 00:00:00 2001
From: Omar Polo <op@omarpolo.com>
Date: Sat, 28 Jan 2023 09:58:35 +0000
Subject: [PATCH] test-system-cmds: use sh -c instead of guile -c

---
 test-suite/standalone/test-system-cmds | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test-suite/standalone/test-system-cmds b/test-suite/standalone/test-system-cmds
index 8c590835d..098808201 100755
--- a/test-suite/standalone/test-system-cmds
+++ b/test-suite/standalone/test-system-cmds
@@ -12,7 +12,7 @@ exec guile -q -s "$0" "$@"
 
   ;; Note: Use double quotes since simple quotes are not supported by
   ;; `cmd.exe' on Windows.
-  (let ((rs (status:exit-val (system "guile -c \"(exit 42)\""))))
+  (let ((rs (status:exit-val (system "sh -c \"exit 42\""))))
     (if (not (= 42 rs))
         (begin
           (simple-format
@@ -22,7 +22,7 @@ exec guile -q -s "$0" "$@"
           (exit 1)))))
 
 (define (test-system*-cmd)
-  (let ((rs (status:exit-val (system* "guile" "-c" "(exit 42)"))))
+  (let ((rs (status:exit-val (system* "sh" "-c" "exit 42"))))
     (if (not (= 42 rs))
         (begin
           (simple-format
-- 
2.39.0





             reply	other threads:[~2023-01-28 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28 10:17 Omar Polo [this message]
2023-01-28 15:43 ` [PATCH] test-system-cmds: use sh -c instead of guile -c Eli Zaretskii
2023-01-30 15:44   ` Omar Polo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2PWE9J0AYIN1N.3GXGS3S39YKS3@venera \
    --to=op@omarpolo.com \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).