From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] test-system-cmds: use sh -c instead of guile -c Date: Sat, 28 Jan 2023 17:43:42 +0200 Message-ID: <83bkmiaclt.fsf@gnu.org> References: <2PWE9J0AYIN1N.3GXGS3S39YKS3@venera> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23867"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Omar Polo Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sat Jan 28 16:44:13 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLnNE-0005yx-Nk for guile-devel@m.gmane-mx.org; Sat, 28 Jan 2023 16:44:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLnMy-0004d2-T9; Sat, 28 Jan 2023 10:43:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLnMw-0004cn-V6 for guile-devel@gnu.org; Sat, 28 Jan 2023 10:43:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLnMw-00086O-7u; Sat, 28 Jan 2023 10:43:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qHzdy1ybZvKtTxGJTzo640Gry+uQYU3dLX5mbTz/n28=; b=KVj7f9scAZki McvWV36xHE0Ayc38XXlFIVB4vt00EFd/KQ62Wrpo+hQGxf1F3jeh65lIicOSTzAP/EAW2gruM1zZS LwmI9PkV0MLXOCHDeDQGL0+u0MGZwYrUkZm9dqgeOCm3L6NHEK5yE2YxPWjmHQtJg/1peIsl+VAk9 etX3yjIJY1CHArYE4nS+X6AhVM6G3rPjLqpOM9OqYITVfXnunmZIkfFw6MX0r57OQCeBBg2pP56xl BvgGUVW5dSKPJ4A72xWVCDxqupUTSFO+RzevtU1f0OaHQ4mATxKlbXoD0lkm90hbRmAXnu4xxWHF/ CM+1itGQSsC2E1YTzEqIrw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLnMv-0007Bj-Dc; Sat, 28 Jan 2023 10:43:53 -0500 In-Reply-To: <2PWE9J0AYIN1N.3GXGS3S39YKS3@venera> (message from Omar Polo on Sat, 28 Jan 2023 11:17:07 +0100) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:21652 Archived-At: > Date: Sat, 28 Jan 2023 11:17:07 +0100 > From: Omar Polo > > I'm not sure this patch is palatable as-is, but I'm adding it to the > OpenBSD port to have less failures in the regress suite. > > The main issue is that "guile" may not be available at test time for > various reasons. (the install prefix is not in $PATH, the executable > may be renamed --program-suffix, etc...) the intent of the test is to test the just-produced Guile binary, so if that binary is not on PATH, the test suite should be fixed so that it is on PATH. > The comment about windows however makes me think that neither sh may > be available. Using meta/guile then is better, other tests are doing > that, but I haven't found the right incantation to do so. I'm responsible for that comment, so when I ran the test suite, it did find the Guile binary in the build tree. Maybe something happened in the meantime that it doesn't now, but the right fix is IMO definitely not to replace Guile with sh, as relying on sh being available is not going to work on Windows. Please instead try to figure out why guile is not on PATH. Running meta/guile might be better, but isn't that a shell script that requires sh as well?