unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Omar Polo <op@omarpolo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] test-system-cmds: use sh -c instead of guile -c
Date: Mon, 30 Jan 2023 16:44:48 +0100	[thread overview]
Message-ID: <3OA53BBFX3LDE.24KEIRPA6607E@venera> (raw)
In-Reply-To: <83bkmiaclt.fsf@gnu.org>

On 2023/01/28 17:43:42 +0200, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sat, 28 Jan 2023 11:17:07 +0100
> > From: Omar Polo <op@omarpolo.com>
> > 
> > I'm not sure this patch is palatable as-is, but I'm adding it to the
> > OpenBSD port to have less failures in the regress suite.
> > 
> > The main issue is that "guile" may not be available at test time for
> > various reasons.  (the install prefix is not in $PATH, the executable
> > may be renamed --program-suffix, etc...)
> 
> the intent of the test is to test the just-produced Guile binary, so
> if that binary is not on PATH, the test suite should be fixed so that
> it is on PATH.

my understanding is that it's using the just-produced Guile binary and
testing wether `system' and `system*' are able spawn executables and
return their exit code.

Anyway, I have to apologise, I can't reproduce the issue anymore.  It
was probably something wrong while I was trying to understand
bug#61095[0].

Consider the patch dropped, the test suite correctly sets up the $PATH
as the README describe.

Sorry for the noise.

Omar Polo

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61095




      reply	other threads:[~2023-01-30 15:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28 10:17 [PATCH] test-system-cmds: use sh -c instead of guile -c Omar Polo
2023-01-28 15:43 ` Eli Zaretskii
2023-01-30 15:44   ` Omar Polo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3OA53BBFX3LDE.24KEIRPA6607E@venera \
    --to=op@omarpolo.com \
    --cc=eliz@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).